fix: Library couldn't be imported as ES module #92
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Changes
Without setting type: "module", the library couldn't be imported as es module. This caused it to throw the following error when trying to
import { Session }from an ES module:By changing the name of the umd package to use
cjsfile ending, it is still working properly as a CJS module as well, not causing any breaking changes.Test
Try to import it in both a CJS and ESM setting, making sure it's working as expected in both.
Example:
test.mjs:
test.cjs: