adding "dir" to layout.ejs html element safely #335
Merged
+6 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
redbugz reviewed Mar 16, 2023
| @@ -1,5 +1,5 @@ | |||
| <!DOCTYPE html> | |||
| <html lang="<%= simpleLocale %>"> | |||
| <html dir="<%= typeof languageDir !== 'undefined' ? languageDir : 'ltr' %>" lang="<%= simpleLocale %>"> | |||
There was a problem hiding this comment.
@kyle-west would it be better to always have dir, and have it be ltr, or do we just add dir="rtl" when it's not the default and omit dir for ltr?
| Have we done any manual validation of this code yet? |
Yes, we tested this frontier-app-react. We added this, and the snow change directly into node_modules and then we manually tested changes. |
redbugz approved these changes Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
adding "dir" for rlt support. Made sure to check typeof
languageDirso if an app gets this update without the corresponding snow update, they won't be broken.