Perlocale tweaks #322
Merged
Perlocale tweaks #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Also add collision detection
joeycozza approved these changes Apr 14, 2022
redbugz commented Apr 14, 2022
| noTypeDefinitions: true, // optional | ||
| detective: { | ||
| es6: { | ||
| mixedImports: true |
There was a problem hiding this comment.
I think this fixes a compilation error I ran into
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Some tweaks and changes we can consider for per-locale
The logging could be opt-in or truncated for final release if we choose
It adds a collision report during coalesce so teams are aware of key collisions