Fix having to defined custom proxies multiple times (FRONTIER-366] #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
If you defined a proxy in setupProxy, it did not apply to storybook or `heroku local`. This change activates proxies in setupProxy in all dev environments.
joeycozza approved these changes Jul 22, 2019
| Awesome! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
If you defined a proxy in setupProxy, it did not apply to storybook
or
heroku local. This change activates proxies in setupProxyin all dev environments.
Fix for https://almtools.ldschurch.org/fhjira/browse/FRONTIER-366
There are other solutions for this, but this one seemed to do the least refactoring, at the expense of overloading the module.exports on setupProxy.
I'm open to other solutions.