Refactor REMOTE_ENV for deployed code #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
When deployed REMOTE_ENV config was overriding TARGET_ENV causing apps to fail to work correctly outside of beta. The scopes the env var overrides and other work to only happen when setProxies is called and when in local dev mode, to remove impact on deployed apps
| The most commonly visible behavior is that auth gets broken in prod because we do not have REMOTE_ENV set in fs-config, so it always defaults to beta, and then overrides TARGET_ENV even when not in dev mode. |
joeycozza approved these changes Jun 14, 2019
spacerockzero approved these changes Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When deployed REMOTE_ENV config was overriding TARGET_ENV causing
apps to fail to work correctly outside of beta.
The scopes the env var overrides and other work to only happen when setProxies
is called and when in local dev mode, to remove impact on deployed apps
Tested by running locally with frontier-app-react and the proxies still worked fine. Need to confirm when deployed.
2 primary changes:
setProxiescall so it will not execute except when using the proxies. Previously it would execute when required, which happens even when not in dev modelocal, so we only overwrite that value in local dev mode.