Skip to content

Add aliases for peer deps #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 3, 2019
Merged

Add aliases for peer deps #125

merged 3 commits into from
Jun 3, 2019

Conversation

@redbugz
Copy link

@redbugz redbugz commented May 25, 2019

This avoids duplicate dependencies when npm linked
@redbugz
Add aliases for peer deps
bbbecfc 
This avoids duplicate dependencies when npm linked
@redbugz redbugz requested a review from joeycozza May 25, 2019 13:38
@joeycozza
Copy link

joeycozza commented Jun 3, 2019

I'm not sure why, but npm run build fails. Says it can't find i18next.
I was able to recreate it locally, but I couldn't figure out WHY.
@redbugz
Try to fix module not found in webpack config
3957236 
Adds aliases as dev dependency to see if it fixes a module not found error when running the webpack build
@joeycozza joeycozza merged commit 729bc83 into develop Jun 3, 2019
@joeycozza joeycozza deleted the aliases branch June 3, 2019 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@redbugz @joeycozza