Fix edge cases with whitespace in enforces-shorthand #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kachkaev commented Jan 15, 2024
| }, | ||
| { | ||
| code: "<div className={ctl(`w-full px-10 py-10 ${live && 'bg-white'}`)}>Trailing space trim issue with fix</div>", | ||
| output: "<div className={ctl(`w-full p-10 ${live && 'bg-white'}`)}>Trailing space trim issue with fix</div>", |
Contributor Author
There was a problem hiding this comment.
Observed output before the fix:
Suggested change
| output: "<div className={ctl(`w-full p-10 ${live && 'bg-white'}`)}>Trailing space trim issue with fix</div>", | |
| output: "<div className={ctl(`w-full p-10${live && 'bg-white'}`)}>Trailing space trim issue with fix</div>", |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
I noticed a small bug when updating a side project to
eslint-plugin-tailwindcss@3.14.0and runningpnpm fix:eslint. See commit history in kachkaev/website#311.Input:
Ouput:
Expected output:
This PR makes sure that a space is not removed between
pt-4and${locale}whentailwindcss/enforces-shorthanddoes an autofix.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
See new unit tests
Test Configuration:
CI
Checklist:
I have made corresponding changes to the documentationN/AAny dependent changes have been merged and published in downstream modulesN/A