Separated IAsyncComputedValueBase<T> from IAsyncComputedValue<T> #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
foxbenjaminfox added a commit to foxbenjaminfox/vue-async-computed-decorator that referenced this pull request Aug 14, 2020
…tions type Thi uses the IAsyncComputedValueBase type added in foxbenjaminfox/vue-async-computed#91
| Thanks! Sorry this took a while, but I've merged this, and published the new version to npm. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hey,
I just separated the
getproperty from the rest of theIAsyncComputedValue<T>interface as discussed here.Since there is already a
IAsyncComputedOptionsdeclaration, I decided to put everything into theIAsyncComputedValueBase<T>interface. This should not introduce any breaking changes.