Add support comments in JSON request body #599 #623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| ref | ||
| .read(collectionStateNotifierProvider.notifier) | ||
| .update(body: value); | ||
| .update(body: removeJsonComments(value)); |
There was a problem hiding this comment.
You have to preserve the comments added by the user. Currently, it removes all comments and saves it. When the user comes back to the request, the body is modified.
Comments are cleaned up only when the request is sent.
| Thank you for the great feedback. I’ve modified the code in the core package to only remove comments when the data is in JSON format, ensuring that the existing data in the editor remains unchanged and comments are removed only during the send request |
| Can I get some feedback on this PR? |
| @FreeBono We are currently occupied with GSoC. The PR has already gone through a round of review. We are working on a merge schedule. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR Description
When a body in JSON format is provided, the function checks whether the body is in JSON format. If it is, the function returns the JSON string with comments removed. If not, it returns the input string as it is.
I have written test cases for removing single-line comments, multi-line comments, and other scenarios.
Related Issues
Checklist
mainbranch before making this PRflutter upgradeand verify)flutter test) and all tests are passingAdded/updated tests?
We encourage you to add relevant test cases.
OS on which you have developed and tested the feature?