Skip to content

Conversation

jvdp1
Copy link
Member

@jvdp1 jvdp1 commented Jan 5, 2020

Additions/changes:

  • some checks in parse_mode to return errors for modes such as rr, rw, r++t, rbt. (Note: I couldn't add these tests in CMake, or it should be one per file)
  • the function open can return the iostat if requested
  • (@certik) since Place ASCII control characters in derived type  #49 has been closed, whitechar is now replaced by is_blank

@scivision : Because I added checks in the function parse_mode, it uses again if statements instead of select case. Good for you?

@scivision
Copy link
Member

yes I think it's fine/necessary to use if here with the more complex conditions now present

@certik
Copy link
Member

certik commented Jan 5, 2020

Thank you @jvdp1 for doing this, it looks really good. I left some comments regarding the API and testing.

@jvdp1
Copy link
Member Author

jvdp1 commented Jan 5, 2020

Thank you @jvdp1 for doing this, it looks really good. I left some comments regarding the API and testing.

Thanks for the review.

@certik
Copy link
Member

certik commented Jan 5, 2020 via email

@jvdp1
Copy link
Member Author

jvdp1 commented Jan 5, 2020

In your last commit, in the tests I think you forgot to add io in the 3rd test from last. (I am on my phone, so I can't comment there directly.)

Resolved!

@certik
Copy link
Member

certik commented Jan 5, 2020 via email

@jvdp1 jvdp1 merged commit c3e4816 into fortran-lang:master Jan 5, 2020
@jvdp1 jvdp1 deleted the parse branch January 5, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants