Fix ci for windows and Intel ifx (#7) #752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Changes: * Windows: GCC 13 * Ubuntu-latest: Intel LLVM (instead of Classic) * Relax test in test_rawmoment due to change from Intel Classic to Intel LLVM
henilp105 approved these changes Dec 26, 2023
There was a problem hiding this comment.
Thanks @jvdp1 , Looks good to me. I have suggested some minor changes. we had been facing similar issue at fpm fortran-lang/fpm#976 .
awvwgk approved these changes Dec 26, 2023
| There are 2 approvals. I will merge it to allow others to be merged too. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes multiple issues with CI (Ubuntu + Intel and Windows)
Changes:
Note: CI for Windows works, but could be most likely improved (but how?)