fixed 32-bit integer overflow in stdlib_io_npy #655
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
32-bit integer overflows in
stdlib_io_npy_save.fypp
andstdlib_io_npy_load.fypp
are fixed from2**32
to2**24
, to become the power of base-number (256) at the 4th digit a base-256 number.To improve readability and understandability, the powers of base-number are refactored from
2**8
,2**16
,2**24
to256**1
,256**2
,256**3
, respectively.The tasks done are summarized as follows:
stdlib_io_npy_save.fypp
stdlib_io_npy_load.fypp
cmake --build build --target test
to run the test npy and confirmed it passedcloses #647
Note that
config/DefaultFlags.cmake
is locally changed to specify compiler flags for nagfor as follows: