option to disable testing by setting BUILD_TESTING to OFF #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Removed enable_testing(), since is called if the tests subdirectory is added
awvwgk reviewed Mar 2, 2022
awvwgk reviewed Mar 2, 2022
awvwgk approved these changes Mar 2, 2022
This was referenced May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Removed enable_testing(), since this seems to be enabled when the subdirectory "tests" is added.
Used the intrinsic CTests name BUILD_TESTING, ref: https://cmake.org/cmake/help/latest/module/CTest.html.
From my understanding, maybe the ideal way of tackling this issue would be to handle BUILD_TESTING as an intrinsic setting in test-drive? Then we might not need the
option(BUILD_TESTING "Define if tests should be enabled" ON)in CMakeLists.txt