Ignore hash testing binaries and logs #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
During a previous PR (#499) I accidentally committed changes which included the addition of some
.binand.txtfiles generated in the hash function testing process. @jvdp1 asked that I remove said files and create a new PR that.gitignores them.I have ignored the
.binfiles by adding them to the top level.gitignore, and addedlogto the.txtfile names so they get caught by an existing entry (*log*.txt) in the.gitignore. Alternatively, I could addtestorlogto the.binfiles as well so they are caught by existing ignore entries, if this is preferable.Related question:
The current
.gitignorealso ends up leaving a lot of untracked files and executables from the manual make process. I think this is largely fine, since we usefyppwhich makes it hard to ignore all.f90files (for example), but am I correct in saying that there are no make rules to remove these in-tree artifacts (I've triedmake -f Makefile.manual clean, but it does not seem to work)?