Skip to content

Conversation

@arjenmarkus
Copy link
Member

The API for the module to manipulate lists of strings has been discussed and this has resulted in the current implementation.

Hm, I cloned the repository via GitHub desktop, but it seems it is part of the original repository. I hope this works anyway.

The API for the module to manipulate lists of strings has been discussed and this has resulted in the current implementation
stringlist_index_add%offset = stringlist_index_add%offset + offset
end function stringlist_index_add

! stringlist_index_substract --
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[misspell] reported by reviewdog 🐶
"substract" is a misspelling of "subtract"

!
! Arguments:
! index Special index
! offset Offset to be substracted
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[misspell] reported by reviewdog 🐶
"substracted" is a misspelling of "subtracted"

@milancurcic
Copy link
Member

milancurcic commented Feb 4, 2021

Thanks @arjenmarkus but this is still from a branch in fortran-lang/stdlib. Can you please follow these steps:

  1. Fork this repo (fortran-lang/stdlib). You will now have arjenmarkus/stdlib.
  2. In GitHub Desktop, clone your fork (arjenmarkus/stdlib), not fortran-lang/stdlib
  3. Create a new branch in it (for example, string-list), and commit your changes to that branch
  4. Open a new Pull Request in fortran-lang/stdlib, based on the string-list branch in arjenmarkus/stdlib.
@milancurcic milancurcic closed this Feb 4, 2021
@arjenmarkus
Copy link
Member Author

arjenmarkus commented Feb 4, 2021 via email

@arjenmarkus
Copy link
Member Author

arjenmarkus commented Feb 4, 2021 via email

@milancurcic
Copy link
Member

@arjenmarkus If you'd like, we can get on a quick Zoom call so that we go through this process together with a screen share.

@arjenmarkus
Copy link
Member Author

arjenmarkus commented Feb 5, 2021 via email

@milancurcic milancurcic deleted the string-list-new branch March 5, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants