Add all three MSYS2 systems to Windows CI #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The two tests slightly exceeding the threshold from 1000*epsilion(1._dp): 1. sum( abs( mean(cd3,2) - sum(cd3,2)/real(size(cd3,2), dp) )) 2. sum( abs( mean(d4,2) - sum(d4,2)/real(size(d4,2), dp) ))
milancurcic approved these changes Dec 28, 2020
Member
milancurcic left a comment
milancurcic left a comment There was a problem hiding this comment.
Windows and CI are not my forte, but this looks good.
Member
| I`ll merge this PR. Thank you @awvwgk for the addition of MSYS@ systems to the CI. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Windows testing is currently limited to the MinGW version preinstalled by choco (GCC 8.1). This PR uses the MSYS2 toolchains to test for the latest GCC/MinGW versions as well.
In total three new CI tests are added:
With the adjustment of the thresholds in test_mean, this PR also fixes #274