Do not use pip to install cmake #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Rather install the binary directly. Fixes fortran-lang#122.
| The CMake installation sped up from 11s to 3s on Linux. I am going to merge this, so that the other PRs start passing. |
| @zbeekman you might want to have a look at this. The Python way to install it failed, so I switched to a simple binary. P.S. It took me over 1h to figure out how to properly do that ---- the usual way of extracting the tarball and creating a symlink in /usr/local/bin completely failed ("broken symlink") but I don't have more time to investigate. The above way works for now. |
| Sure I’ll take a look. …On Thu, Jan 23, 2020 at 5:59 PM Ondřej Čertík ***@***.***> wrote: @zbeekman <https://github.com/zbeekman> you might want to have a look at this. The Python way to install it failed, so I switched to a simple binary. P.S. It took me over 1h to figure out how to properly do that ---- the usual way of extracting the tarball and creating a symlink in /usr/local/bin completely failed ("broken symlink") but I don't have more time to investigate. The above way works for now. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#123?email_source=notifications&email_token=AACEIPG7W3D2MUVHZVOTWF3Q7IOO5A5CNFSM4KK5Z56KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJZFETI#issuecomment-577917517>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACEIPENBOQYHQ4ES7MICN3Q7IOO5ANCNFSM4KK5Z56A> . |
| LGTM. I typically use the self-extracting script rather than a tarball, but this seems like a perfectly good approach, and, apparently, CMake is already the latest version on macOS I guess. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #122.