- Notifications
You must be signed in to change notification settings - Fork 8
Implement timeout feature #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rajkumardongre, mostly looks good, I added a few requests. Also, tests for timeout are missing.
Thanks @milancurcic, I have made the required changes |
Thanks, @interkosmos, I have made the required changes |
@rajkumardongre can you resolve the conflicts (just merging main into this branch may be sufficient) and merge this PR when ready? |
I think httpbin is flaky here (test failing sometimes for basic auth). Any other service we can use for this? |
Thanks @milancurcic, I found https://postman-echo.com/ as an alternative. |
test/test_auth.f90 Outdated
! setting username and password | ||
auth = pair_type('user', 'passwd') | ||
res = request(url='https://httpbin.org/basic-auth/user/passwd', auth=auth) | ||
res = request(url='https://postman-echo.com/get', auth=auth) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this need to be?
res = request(url='https://postman-echo.com/get', auth=auth) | |
res = request(url='https://postman-echo.com/basic-auth', auth=auth) |
I was considering whether we should make the procedures |
Is it important for this PR? It seems to me like a separate issue. We can consider |
Ok, we can discuss it on other PR |
No description provided.