filesystem_utilities.c: use INODE64 on 64-bit, but not on 32-bit #997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
perazz approved these changes Feb 16, 2024
Member
perazz left a comment
perazz left a comment There was a problem hiding this comment.
I don't have a way to test it but I'm guessing it works of course. Thanks for sharing @barracuda156, LGTM.
Contributor Author
| @perazz I guess we should be good to merge this. I won’t be able to deal with |
awvwgk approved these changes Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes: #993
fpmoni386with this fix, it seems to work just fine (like it does on 32-bitppc). I tried to build several ports that usefpm, everything worked as expected. (Without this it is just broken: there is no_opendir$INODE64fori386.)ppc64at the moment, the symbol is in fact available inlibSystemfor this arch, so presumably we do not need to disable this chunk there. (__POWERPC__is defined forppcandppc64both, while__ppc__– only forppc.)