Skip to content

Fix convert_to_absolute_path #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2023
Merged

Fix convert_to_absolute_path #940

merged 1 commit into from
Jun 17, 2023

Conversation

@minhqdao
Copy link
Contributor

@minhqdao minhqdao commented Jun 15, 2023 •
edited
Loading

Hotfixing a bug in convert_to_absolute_path.

This doesn't work:

 character(len=*), intent(inout) :: path ... path = absolute_path

Therefore using a deferred type parameter.

 character(len=:), allocatable, intent(inout) :: path ... path = absolute_path
henilp105
henilp105 approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@henilp105 henilp105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @minhqdao , looks good to me.
awvwgk
awvwgk approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing.
@minhqdao minhqdao merged commit 969a452 into main Jun 17, 2023
@minhqdao minhqdao deleted the fix-convert-to-absolute-path branch June 17, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants

@minhqdao @awvwgk @henilp105 @arteevraina