Refactor: split fpm_meta into parts #1119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Merged
perazz reviewed Apr 6, 2025
Member
perazz left a comment
perazz left a comment There was a problem hiding this comment.
Thank you for this PR @krystophny, I think it is almost ready to merge, here are a few comments.
Contributor Author
| Thanks @perazz ! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Splitting the already too large module
fpm_metainto specialized parts is a necessary step before supporting more metapackages. I plan to implementnetcdf,blas/lapack(fromopenblasandMKL),fftw,suitesparsesubsequently. This will be done in the generic way possible withpkg_config, depending on how well the support is on distros (Focus on Debian, Arch, Nix and typical HPC clusters withmodule). See #439 and #445 .@perazz do you think you could review this PR?