Support create_term and get_vnc API for Node itself #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Can you please fix the failing tests? |
| Test failure is due to deprecated v1 upload-artifact. I bumped it in #100 |
| Hey @davispuh, Can you please also add the tests for it? |
| That seems like waste of time considering bunch of my PRs has been sitting for months without being merged. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently you can create Terminal/VNC for VM using
create_term/get_vncAPIs but there isn't API for the Proxmox node terminal itself.So implement such functionality by allowing current
create_term/get_vncto be used for this case aswell when bothtypeandvmidisnil