Skip to content

Design doc for InputDecoration.centerFloatingLabel #6284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2021
Merged

Design doc for InputDecoration.centerFloatingLabel #6284

merged 2 commits into from
Sep 16, 2021

Conversation

@werainkhatri
Copy link
Member

PR related to Design Doc: flutter/flutter#90157
@google-cla google-cla bot added the cla: yes Contributor has signed the Contributor License Agreement label Sep 15, 2021
sfshaza2
sfshaza2 previously approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@sfshaza2
Copy link
Contributor

@werainkhatri, can you update this PR? We are no longer using the "archived-master" branch (that was formerly the "master" branch. We now use the "main" branch. Once you fix the PR I can land. Thx!
@google-cla
Copy link

google-cla bot commented Sep 16, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.
@google-cla google-cla bot added cla: no Contributor has not signed the Contributor License Agreement and removed cla: yes Contributor has signed the Contributor License Agreement labels Sep 16, 2021
@werainkhatri werainkhatri changed the base branch from archived-master to main September 16, 2021 19:57
@werainkhatri
Copy link
Member Author

werainkhatri commented Sep 16, 2021 •
edited
Loading

Is this fine? 😬 Or should I raise a new PR?
sfshaza2
sfshaza2 approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@googlebot googlebot added cla: yes Contributor has signed the Contributor License Agreement and removed cla: no Contributor has not signed the Contributor License Agreement labels Sep 16, 2021
@sfshaza2 sfshaza2 merged commit 1f455a6 into flutter:main Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Contributor has signed the Contributor License Agreement

3 participants

@werainkhatri @sfshaza2 @googlebot