Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Move custom analysis options into sub-packages #4603

Merged
merged 2 commits into from
Dec 9, 2021
Merged

Move custom analysis options into sub-packages #4603

merged 2 commits into from
Dec 9, 2021

Conversation

@stuartmorgan-g
Copy link
Contributor

When the legacy analysis options were bulk-added to the repository to
allow transitioning incrementally to the Flutter analysis options, they
were added to top-level plugin groups. This makes it harder to migrate
incrementally, and also means that when we add a new sub-package (e.g, a
web or desktop implementation) it's automatically using the legacy
options.

This moves all the legacy option files into each individual package, and
updates the allow list for the tool accordingly, so that migration can
be done package by package.

No version change: Only affects development

No CHANGELOG change: no conceptual change that's interesting to document, since the analysis options for all plugins are still the same.

Part of flutter/flutter#76229

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.
@stuartmorgan-g
Move custom analysis options into sub-packages
ec56144 
When the legacy analysis options were bulk-added to the repository to allow transitioning incrementally to the Flutter analysis options, they were added to top-level plugin groups. This makes it harder to migrate incrementally, and also means that when we add a new sub-package (e.g, a web or desktop implementation) it's automatically using the legacy options. This moves all the legacy option files into each individual package, and updates the allow list for the tool accordingly, so that migration can be done package by package.
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.
cyanglaz
cyanglaz approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@stuartmorgan-g stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Dec 9, 2021
@stuartmorgan-g stuartmorgan-g merged commit 64c222d into flutter:master Dec 9, 2021
@stuartmorgan-g stuartmorgan-g deleted the analysis-options-shard branch December 9, 2021 22:02
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 9, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 9, 2021
@engine-flutter-autoroll
64c222d Move custom analysis options into sub-packages (flutter/plugi…
5b4f39a 
…ns#4603)
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
@stuartmorgan-g @amantoux
Move custom analysis options into sub-packages (flutter#4603)
b96b975 
When the legacy analysis options were bulk-added to the repository to allow transitioning incrementally to the Flutter analysis options, they were added to top-level plugin groups. This makes it harder to migrate incrementally, and also means that when we add a new sub-package (e.g, a web or desktop implementation) it's automatically using the legacy options. This moves all the legacy option files into each individual package, and updates the allow list for the tool accordingly, so that migration can be done package by package.
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@stuartmorgan-g @KyleFin
Move custom analysis options into sub-packages (flutter#4603)
a97a072 
When the legacy analysis options were bulk-added to the repository to allow transitioning incrementally to the Flutter analysis options, they were added to top-level plugin groups. This makes it harder to migrate incrementally, and also means that when we add a new sub-package (e.g, a web or desktop implementation) it's automatically using the legacy options. This moves all the legacy option files into each individual package, and updates the allow list for the tool accordingly, so that migration can be done package by package.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs tests p: camera p: google_maps_flutter p: google_sign_in p: image_picker p: video_player platform-web waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

2 participants

@stuartmorgan-g @cyanglaz