[shared_preferences] Federate mobile implementations

packages/shared_preferences/shared_preferences/CHANGELOG.md

@@ -1,6 +1,7 @@
 ## NEXT
 
 * Fixes newly enabled analyzer options.
+* Moved Android and iOS implementations to federated packages.
 
 ## 2.0.8
 

packages/shared_preferences/shared_preferences/example/android/app/build.gradle

@@ -33,12 +33,12 @@ android {
  }
 
  defaultConfig {
- // TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
- applicationId "io.flutter.plugins.example"
+ applicationId "io.flutter.plugins.sharedpreferencesexample"
  minSdkVersion 16
  targetSdkVersion 30
  versionCode flutterVersionCode.toInteger()
  versionName flutterVersionName
+ testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
  }
 
  buildTypes {

packages/shared_preferences/shared_preferences/example/android/app/src/androidTest/java/io/flutter/plugins/DartIntegrationTest.java

@@ -0,0 +1,14 @@
+// Copyright 2013 The Flutter Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package io.flutter.plugins;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+
+@Retention(RetentionPolicy.RUNTIME)
+@Target(ElementType.TYPE)
+public @interface DartIntegrationTest {}

packages/shared_preferences/shared_preferences/example/android/app/src/androidTest/java/io/flutter/plugins/sharedpreferencesexample/MainActivityTest.java

@@ -0,0 +1,19 @@
+// Copyright 2013 The Flutter Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package io.flutter.plugins.sharedpreferencesexample;
+
+import androidx.test.rule.ActivityTestRule;
+import dev.flutter.plugins.integration_test.FlutterTestRunner;
+import io.flutter.embedding.android.FlutterActivity;
+import io.flutter.plugins.DartIntegrationTest;
+import org.junit.Rule;
+import org.junit.runner.RunWith;
+
+@DartIntegrationTest
+@RunWith(FlutterTestRunner.class)
+public class MainActivityTest {
+ @Rule
+ public ActivityTestRule<FlutterActivity> rule = new ActivityTestRule<>(FlutterActivity.class);
+}

packages/shared_preferences/shared_preferences/example/android/app/src/debug/AndroidManifest.xml

@@ -1,5 +1,5 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
- package="io.flutter.plugins.example">
+ package="io.flutter.plugins.sharedpreferencesexample">
  <!-- Flutter needs it to communicate with the running application
  to allow setting breakpoints, to provide hot reload, etc.
  -->

packages/shared_preferences/shared_preferences/example/android/app/src/main/AndroidManifest.xml

@@ -1,10 +1,10 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
- package="io.flutter.plugins.example">
+ package="io.flutter.plugins.sharedpreferencesexample">
  <application
  android:label="example"
  android:icon="@mipmap/ic_launcher">
  <activity
- android:name=".MainActivity"
+ android:name="io.flutter.embedding.android.FlutterActivity"
  android:launchMode="singleTop"
  android:theme="@style/LaunchTheme"
  android:configChanges="orientation|keyboardHidden|keyboard|screenSize|smallestScreenSize|locale|layoutDirection|fontScale|screenLayout|density|uiMode"

packages/shared_preferences/shared_preferences/example/android/app/src/profile/AndroidManifest.xml

@@ -1,5 +1,5 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
- package="io.flutter.plugins.example">
+ package="io.flutter.plugins.sharedpreferencesexample">
  <!-- Flutter needs it to communicate with the running application
  to allow setting breakpoints, to provide hot reload, etc.
  -->

packages/shared_preferences/shared_preferences/example/integration_test/shared_preferences_test.dart

@@ -2,10 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import 'dart:async';
-import 'dart:io';
-
-import 'package:flutter/services.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:integration_test/integration_test.dart';
 import 'package:shared_preferences/shared_preferences.dart';
@@ -101,33 +97,5 @@ void main() {
  // The last write should win.
  expect(preferences.getInt('int'), writeCount);
  });
-
- testWidgets(
- 'string clash with lists, big integers and doubles (Android only)',
- (WidgetTester _) async {
- await preferences.clear();
- // special prefixes plus a string value
- expect(
- // prefix for lists
- preferences.setString('String',
- 'VGhpcyBpcyB0aGUgcHJlZml4IGZvciBhIGxpc3Qu' + testString),
- throwsA(isA<PlatformException>()));
- await preferences.reload();
- expect(preferences.getString('String'), null);
- expect(
- // prefix for big integers
- preferences.setString('String',
- 'VGhpcyBpcyB0aGUgcHJlZml4IGZvciBCaWdJbnRlZ2Vy' + testString),
- throwsA(isA<PlatformException>()));
- await preferences.reload();
- expect(preferences.getString('String'), null);
- expect(
- // prefix for doubles
- preferences.setString('String',
- 'VGhpcyBpcyB0aGUgcHJlZml4IGZvciBEb3VibGUu' + testString),
- throwsA(isA<PlatformException>()));
- await preferences.reload();
- expect(preferences.getString('String'), null);
- }, skip: !Platform.isAndroid);
  });
 }

packages/shared_preferences/shared_preferences/example/ios/Podfile

@@ -29,9 +29,6 @@ flutter_ios_podfile_setup
 
 target 'Runner' do
  flutter_install_all_ios_pods File.dirname(File.realpath(__FILE__))
- target 'RunnerTests' do
- inherit! :search_paths
- end
 end
 
 post_install do |installer|

packages/shared_preferences/shared_preferences/example/ios/Runner.xcodeproj/project.pbxproj

@@ -9,26 +9,14 @@
 /* Begin PBXBuildFile section */
 2D92224B1EC342E7007564B0 /* GeneratedPluginRegistrant.m in Sources */ = {isa = PBXBuildFile; fileRef = 2D92224A1EC342E7007564B0 /* GeneratedPluginRegistrant.m */; };
 3B3967161E833CAA004F5970 /* AppFrameworkInfo.plist in Resources */ = {isa = PBXBuildFile; fileRef = 3B3967151E833CAA004F5970 /* AppFrameworkInfo.plist */; };
-4E8BDD90E81668641A750C18 /* libPods-RunnerTests.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 556D8EFC85341B7D1FDF536D /* libPods-RunnerTests.a */; };
 66F8BCECCEFF62F4071D2DFC /* libPods-Runner.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 12E03CD14DABAA3AD3923183 /* libPods-Runner.a */; };
 978B8F6F1D3862AE00F588F7 /* AppDelegate.m in Sources */ = {isa = PBXBuildFile; fileRef = 7AFFD8EE1D35381100E5BB4D /* AppDelegate.m */; };
 97C146F31CF9000F007C117D /* main.m in Sources */ = {isa = PBXBuildFile; fileRef = 97C146F21CF9000F007C117D /* main.m */; };
 97C146FC1CF9000F007C117D /* Main.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 97C146FA1CF9000F007C117D /* Main.storyboard */; };
 97C146FE1CF9000F007C117D /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 97C146FD1CF9000F007C117D /* Assets.xcassets */; };
 97C147011CF9000F007C117D /* LaunchScreen.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 97C146FF1CF9000F007C117D /* LaunchScreen.storyboard */; };
-F76AC2092669B6AE0040C8BC /* SharedPreferencesTests.m in Sources */ = {isa = PBXBuildFile; fileRef = F76AC2082669B6AE0040C8BC /* SharedPreferencesTests.m */; };
 /* End PBXBuildFile section */
 
-/* Begin PBXContainerItemProxy section */
-F76AC20B2669B6AE0040C8BC /* PBXContainerItemProxy */ = {
-isa = PBXContainerItemProxy;
-containerPortal = 97C146E61CF9000F007C117D /* Project object */;
-proxyType = 1;
-remoteGlobalIDString = 97C146ED1CF9000F007C117D;
-remoteInfo = Runner;
-};
-/* End PBXContainerItemProxy section */
-
 /* Begin PBXCopyFilesBuildPhase section */
 9705A1C41CF9048500538489 /* Embed Frameworks */ = {
 isa = PBXCopyFilesBuildPhase;
@@ -63,9 +51,6 @@
 97C147021CF9000F007C117D /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
 A2FC4F1DC78D7C01312F877F /* Pods-RunnerTests.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-RunnerTests.debug.xcconfig"; path = "Pods/Target Support Files/Pods-RunnerTests/Pods-RunnerTests.debug.xcconfig"; sourceTree = "<group>"; };
 D896CE48B6CC2EB7D42CB6B6 /* Pods-RunnerTests.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-RunnerTests.release.xcconfig"; path = "Pods/Target Support Files/Pods-RunnerTests/Pods-RunnerTests.release.xcconfig"; sourceTree = "<group>"; };
-F76AC2062669B6AE0040C8BC /* RunnerTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = RunnerTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
-F76AC2082669B6AE0040C8BC /* SharedPreferencesTests.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = SharedPreferencesTests.m; sourceTree = "<group>"; };
-F76AC20A2669B6AE0040C8BC /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
 /* End PBXFileReference section */
 
 /* Begin PBXFrameworksBuildPhase section */
@@ -77,14 +62,6 @@
 );
 runOnlyForDeploymentPostprocessing = 0;
 };
-F76AC2032669B6AE0040C8BC /* Frameworks */ = {
-isa = PBXFrameworksBuildPhase;
-buildActionMask = 2147483647;
-files = (
-4E8BDD90E81668641A750C18 /* libPods-RunnerTests.a in Frameworks */,
-);
-runOnlyForDeploymentPostprocessing = 0;
-};
 /* End PBXFrameworksBuildPhase section */
 
 /* Begin PBXGroup section */
@@ -115,7 +92,6 @@
 children = (
 9740EEB11CF90186004384FC /* Flutter */,
 97C146F01CF9000F007C117D /* Runner */,
-F76AC2072669B6AE0040C8BC /* RunnerTests */,
 97C146EF1CF9000F007C117D /* Products */,
 840012C8B5EDBCF56B0E4AC1 /* Pods */,
 CF3B75C9A7D2FA2A4C99F110 /* Frameworks */,
@@ -126,7 +102,6 @@
 isa = PBXGroup;
 children = (
 97C146EE1CF9000F007C117D /* Runner.app */,
-F76AC2062669B6AE0040C8BC /* RunnerTests.xctest */,
 );
 name = Products;
 sourceTree = "<group>";
@@ -164,15 +139,6 @@
 name = Frameworks;
 sourceTree = "<group>";
 };
-F76AC2072669B6AE0040C8BC /* RunnerTests */ = {
-isa = PBXGroup;
-children = (
-F76AC2082669B6AE0040C8BC /* SharedPreferencesTests.m */,
-F76AC20A2669B6AE0040C8BC /* Info.plist */,
-);
-path = RunnerTests;
-sourceTree = "<group>";
-};
 /* End PBXGroup section */
 
 /* Begin PBXNativeTarget section */
@@ -197,25 +163,6 @@
 productReference = 97C146EE1CF9000F007C117D /* Runner.app */;
 productType = "com.apple.product-type.application";
 };
-F76AC2052669B6AE0040C8BC /* RunnerTests */ = {
-isa = PBXNativeTarget;
-buildConfigurationList = F76AC20F2669B6AE0040C8BC /* Build configuration list for PBXNativeTarget "RunnerTests" */;
-buildPhases = (
-DB9B98025BDEFED85B1B62A7 /* [CP] Check Pods Manifest.lock */,
-F76AC2022669B6AE0040C8BC /* Sources */,
-F76AC2032669B6AE0040C8BC /* Frameworks */,
-F76AC2042669B6AE0040C8BC /* Resources */,
-);
-buildRules = (
-);
-dependencies = (
-F76AC20C2669B6AE0040C8BC /* PBXTargetDependency */,
-);
-name = RunnerTests;
-productName = RunnerTests;
-productReference = F76AC2062669B6AE0040C8BC /* RunnerTests.xctest */;
-productType = "com.apple.product-type.bundle.unit-test";
-};
 /* End PBXNativeTarget section */
 
 /* Begin PBXProject section */
@@ -228,11 +175,6 @@
 97C146ED1CF9000F007C117D = {
 CreatedOnToolsVersion = 7.3.1;
 };
-F76AC2052669B6AE0040C8BC = {
-CreatedOnToolsVersion = 12.5;
-ProvisioningStyle = Automatic;
-TestTargetID = 97C146ED1CF9000F007C117D;
-};
 };
 };
 buildConfigurationList = 97C146E91CF9000F007C117D /* Build configuration list for PBXProject "Runner" */;
@@ -249,7 +191,6 @@
 projectRoot = "";
 targets = (
 97C146ED1CF9000F007C117D /* Runner */,
-F76AC2052669B6AE0040C8BC /* RunnerTests */,
 );
 };
 /* End PBXProject section */
@@ -266,13 +207,6 @@
 );
 runOnlyForDeploymentPostprocessing = 0;
 };
-F76AC2042669B6AE0040C8BC /* Resources */ = {
-isa = PBXResourcesBuildPhase;
-buildActionMask = 2147483647;
-files = (
-);
-runOnlyForDeploymentPostprocessing = 0;
-};
 /* End PBXResourcesBuildPhase section */
 
 /* Begin PBXShellScriptBuildPhase section */
@@ -322,28 +256,6 @@
 shellScript = "diff \"${PODS_PODFILE_DIR_PATH}/Podfile.lock\" \"${PODS_ROOT}/Manifest.lock\" > /dev/null\nif [ $? != 0 ] ; then\n # print error to STDERR\n echo \"error: The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.\" >&2\n exit 1\nfi\n# This output is used by Xcode 'outputs' to avoid re-running this script phase.\necho \"SUCCESS\" > \"${SCRIPT_OUTPUT_FILE_0}\"\n";
 showEnvVarsInLog = 0;
 };
-DB9B98025BDEFED85B1B62A7 /* [CP] Check Pods Manifest.lock */ = {
-isa = PBXShellScriptBuildPhase;
-buildActionMask = 2147483647;
-files = (
-);
-inputFileListPaths = (
-);
-inputPaths = (
-"${PODS_PODFILE_DIR_PATH}/Podfile.lock",
-"${PODS_ROOT}/Manifest.lock",
-);
-name = "[CP] Check Pods Manifest.lock";
-outputFileListPaths = (
-);
-outputPaths = (
-"$(DERIVED_FILE_DIR)/Pods-RunnerTests-checkManifestLockResult.txt",
-);
-runOnlyForDeploymentPostprocessing = 0;
-shellPath = /bin/sh;
-shellScript = "diff \"${PODS_PODFILE_DIR_PATH}/Podfile.lock\" \"${PODS_ROOT}/Manifest.lock\" > /dev/null\nif [ $? != 0 ] ; then\n # print error to STDERR\n echo \"error: The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.\" >&2\n exit 1\nfi\n# This output is used by Xcode 'outputs' to avoid re-running this script phase.\necho \"SUCCESS\" > \"${SCRIPT_OUTPUT_FILE_0}\"\n";
-showEnvVarsInLog = 0;
-};
 /* End PBXShellScriptBuildPhase section */
 
 /* Begin PBXSourcesBuildPhase section */
@@ -357,24 +269,8 @@
 );
 runOnlyForDeploymentPostprocessing = 0;
 };
-F76AC2022669B6AE0040C8BC /* Sources */ = {
-isa = PBXSourcesBuildPhase;
-buildActionMask = 2147483647;
-files = (
-F76AC2092669B6AE0040C8BC /* SharedPreferencesTests.m in Sources */,
-);
-runOnlyForDeploymentPostprocessing = 0;
-};
 /* End PBXSourcesBuildPhase section */
 
-/* Begin PBXTargetDependency section */
-F76AC20C2669B6AE0040C8BC /* PBXTargetDependency */ = {
-isa = PBXTargetDependency;
-target = 97C146ED1CF9000F007C117D /* Runner */;
-targetProxy = F76AC20B2669B6AE0040C8BC /* PBXContainerItemProxy */;
-};
-/* End PBXTargetDependency section */
-
 /* Begin PBXVariantGroup section */
 97C146FA1CF9000F007C117D /* Main.storyboard */ = {
 isa = PBXVariantGroup;
@@ -543,34 +439,6 @@
 };
 name = Release;
 };
-F76AC20D2669B6AE0040C8BC /* Debug */ = {
-isa = XCBuildConfiguration;
-baseConfigurationReference = A2FC4F1DC78D7C01312F877F /* Pods-RunnerTests.debug.xcconfig */;
-buildSettings = {
-BUNDLE_LOADER = "$(TEST_HOST)";
-CODE_SIGN_STYLE = Automatic;
-INFOPLIST_FILE = RunnerTests/Info.plist;
-LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
-PRODUCT_BUNDLE_IDENTIFIER = dev.flutter.plugins.RunnerTests;
-PRODUCT_NAME = "$(TARGET_NAME)";
-TEST_HOST = "$(BUILT_PRODUCTS_DIR)/Runner.app/Runner";
-};
-name = Debug;
-};
-F76AC20E2669B6AE0040C8BC /* Release */ = {
-isa = XCBuildConfiguration;
-baseConfigurationReference = D896CE48B6CC2EB7D42CB6B6 /* Pods-RunnerTests.release.xcconfig */;
-buildSettings = {
-BUNDLE_LOADER = "$(TEST_HOST)";
-CODE_SIGN_STYLE = Automatic;
-INFOPLIST_FILE = RunnerTests/Info.plist;
-LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
-PRODUCT_BUNDLE_IDENTIFIER = dev.flutter.plugins.RunnerTests;
-PRODUCT_NAME = "$(TARGET_NAME)";
-TEST_HOST = "$(BUILT_PRODUCTS_DIR)/Runner.app/Runner";
-};
-name = Release;
-};
 /* End XCBuildConfiguration section */
 
 /* Begin XCConfigurationList section */
@@ -592,15 +460,6 @@
 defaultConfigurationIsVisible = 0;
 defaultConfigurationName = Release;
 };
-F76AC20F2669B6AE0040C8BC /* Build configuration list for PBXNativeTarget "RunnerTests" */ = {
-isa = XCConfigurationList;
-buildConfigurations = (
-F76AC20D2669B6AE0040C8BC /* Debug */,
-F76AC20E2669B6AE0040C8BC /* Release */,
-);
-defaultConfigurationIsVisible = 0;
-defaultConfigurationName = Release;
-};
 /* End XCConfigurationList section */
 };
 rootObject = 97C146E61CF9000F007C117D /* Project object */;