- Notifications
You must be signed in to change notification settings - Fork 9.7k
[webview_flutter] Update webview platform interface with new methods for running JavaScript. #4401
[webview_flutter] Update webview platform interface with new methods for running JavaScript. #4401
Conversation
…e with new methods for running JavaScript
| @mvanbeusekom @stuartmorgan Let me know what you think about that and I can make a quick refactor to merge them if needed. |
| In case of the |
| @mvanbeusekom Gotcha, I'll quickly fix that |
...lutter/webview_flutter_platform_interface/lib/src/method_channel/webview_method_channel.dart Outdated Show resolved Hide resolved
...bview_flutter_platform_interface/lib/src/platform_interface/webview_platform_controller.dart Outdated Show resolved Hide resolved
...bview_flutter_platform_interface/lib/src/platform_interface/webview_platform_controller.dart Outdated Show resolved Hide resolved
...bview_flutter_platform_interface/lib/src/platform_interface/webview_platform_controller.dart Outdated Show resolved Hide resolved
| PR feedback has been implemented. All cases of "JavaScript" have been refactored to "Javascript" in this and the other PRs to maintain consistency with existing names for other methods & classes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits.
packages/webview_flutter/webview_flutter_platform_interface/CHANGELOG.md Outdated Show resolved Hide resolved
...bview_flutter_platform_interface/lib/src/platform_interface/webview_platform_controller.dart Outdated Show resolved Hide resolved
...bview_flutter_platform_interface/lib/src/platform_interface/webview_platform_controller.dart Outdated Show resolved Hide resolved
...bview_flutter_platform_interface/lib/src/platform_interface/webview_platform_controller.dart Show resolved Hide resolved
.../webview_flutter_platform_interface/test/src/method_channel/webview_method_channel_test.dart Outdated Show resolved Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| This pull request is not suitable for automatic merging in its current state.
|
…methods for running JavaScript. (flutter/plugins#4401)
…methods for running JavaScript. (flutter/plugins#4401) (#91352)
* master: [webview_flutter] Update webview platform interface with new methods for running JavaScript. (flutter#4401)
* master: [webview_flutter] Update webview platform interface with new methods for running JavaScript. (flutter#4401)
* master: (1126 commits) [webview_flutter] Adjust test URLs again (flutter#4407) [google_sign_in] Add serverAuthCode attribute to google_sign_in_platform_interface user data (flutter#4179) [camera] Add filter for unsupported cameras on Android (flutter#4418) [webview_flutter] Update webview platform interface with new methods for running JavaScript. (flutter#4401) [webview_flutter] Add zoomEnabled to webview flutter platform interface (flutter#4404) [ci] Remove obsolete Dockerfile (flutter#4405) Fix order-dependant platform interface tests (flutter#4406) [google_maps_flutter]: LatLng longitude loses precision in constructor #90574 (flutter#4374) [google_maps_flutter] Add Marker drag events (flutter#2838) [flutter_plugin_tools] Validate pubspec description (flutter#4396) Add file_selector to the repo list (flutter#4395) [in_app_purchase] Fix in_app_purchase_android/README.md (flutter#4363) [google_maps_flutter_web] Add Marker drag events (flutter#4385) [webview_flutter] Fixed todos in FlutterWebView.java (flutter#4394) Handle `PurchaseStatus.restored` correctly in example. (flutter#4393) Handle restored purchases in iOS example app (flutter#4392) [file_selector] Remove custom analysis options (flutter#4382) [flutter_plugin_tools] Check licenses in Kotlin (flutter#4373) Fixed _CastError when running example App (flutter#4390) [in_app_purchase] Ensure the introductoryPriceMicros field is transported as a String. (flutter#4370) ... # Conflicts: # packages/quick_actions/ios/Classes/FLTQuickActionsPlugin.m
…for running JavaScript. (flutter#4401)
…methods for running JavaScript. (flutter/plugins#4401) (flutter#91352)
…for running JavaScript. (flutter#4401)
…for running JavaScript. (flutter#4401)
This PR adds two new platform interface methods,
runJavaScriptandrunJavaScriptForResult, to supersedeevaluateJavascript.This is meant as a solution to the issue mentioned in flutter/flutter#66318, and was discussed offline with @mvanbeusekom and @stuartmorgan.
Relevant issue:
Pre-launch Checklist
dart format.)[shared_preferences]///).