[flutter_conductor] catch and warn when pushing working branch to mirror #94506
Conversation
| It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard bot added the c: contributor-productivity 
christopherfujino changed the title 
| friendly ping @godofredoc |
| } | ||
| } | ||
| | ||
| static final RegExp _pushRejectedPattern = RegExp( |
There was a problem hiding this comment.
Is there a way to detect this error by exit code instead of message? using something like exit code can make this code more deterministic.
There was a problem hiding this comment.
Unfortunately not. This particular error is exit 1, as are almost all errors, per: https://stackoverflow.com/questions/4917871/does-git-return-specific-return-error-codes
3 participants
Catch and warn when git pushing working branch to mirror is rejected because the remote branch already exists with different commits. Also, pipe through
--forceflag to allow git pushing past this.Fixes #94479