This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Work around wrong pointerId in coalesced events in iOS Safari 18.2 #56719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ditman approved these changes Nov 20, 2024
mdebbar added the autosubmit 
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 21, 2024
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Nov 21, 2024
…159270) flutter/engine@523d381...78b87f3 2024-11-21 mdebbar@google.com [web] Make sure to include all split fonts (flutter/engine#56733) 2024-11-21 mdebbar@google.com [web] Work around wrong pointerId in coalesced events in iOS Safari 18.2 (flutter/engine#56719) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 tasks
| Failed to create CP due to merge conflicts. |
mdebbar added a commit to mdebbar/engine that referenced this pull request Dec 2, 2024
…ri 18.2 (flutter#56719) In iOS 18.2, Safari [added support](https://developer.apple.com/documentation/safari-release-notes/safari-18_2-release-notes#Web-API) for the [`getCoalescedEvents`](https://developer.mozilla.org/en-US/docs/Web/API/PointerEvent/getCoalescedEvents) API. That being said, the API seems to be incomplete (or at least doesn't match other browsers' behavior). The coalesced events lack a [`pointerId`](https://developer.mozilla.org/en-US/docs/Web/API/PointerEvent/pointerId) and [`target`](https://developer.mozilla.org/en-US/docs/Web/API/Event/target) properties. I'm not sure if this issue will be fixed in the stable release of iOS 18.2, so in the meantime, this PR implements a workaround to avoid this issue. Fixes flutter/flutter#158299 Fixes flutter/flutter#155987
mdebbar added a commit to mdebbar/engine that referenced this pull request Dec 2, 2024
… Safari 18.2 (flutter#56719) In iOS 18.2, Safari [added support](https://developer.apple.com/documentation/safari-release-notes/safari-18_2-release-notes#Web-API) for the [`getCoalescedEvents`](https://developer.mozilla.org/en-US/docs/Web/API/PointerEvent/getCoalescedEvents) API. That being said, the API seems to be incomplete (or at least doesn't match other browsers' behavior). The coalesced events lack a [`pointerId`](https://developer.mozilla.org/en-US/docs/Web/API/PointerEvent/pointerId) and [`target`](https://developer.mozilla.org/en-US/docs/Web/API/Event/target) properties. I'm not sure if this issue will be fixed in the stable release of iOS 18.2, so in the meantime, this PR implements a workaround to avoid this issue. Fixes flutter/flutter#158299 Fixes flutter/flutter#155987
This was referenced Dec 2, 2024
Merged
auto-submit bot pushed a commit that referenced this pull request Dec 5, 2024
These changes are mainly things I missed in #56719 Fixes flutter/flutter#159804
auto-submit bot pushed a commit that referenced this pull request Dec 10, 2024
… Safari 18.2 (#56719) (#56905) Manual cherry pick for #56719 Cherrypick request: flutter/flutter#159692
| I don't understand how I should modify this problem in Flutter 3.10.6 |
flutteractionsbot pushed a commit to flutteractionsbot/engine that referenced this pull request Dec 17, 2024
These changes are mainly things I missed in flutter#56719 Fixes flutter/flutter#159804
7 tasks
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
…8.2 (flutter/engine#56719) In iOS 18.2, Safari [added support](https://developer.apple.com/documentation/safari-release-notes/safari-18_2-release-notes#Web-API) for the [`getCoalescedEvents`](https://developer.mozilla.org/en-US/docs/Web/API/PointerEvent/getCoalescedEvents) API. That being said, the API seems to be incomplete (or at least doesn't match other browsers' behavior). The coalesced events lack a [`pointerId`](https://developer.mozilla.org/en-US/docs/Web/API/PointerEvent/pointerId) and [`target`](https://developer.mozilla.org/en-US/docs/Web/API/Event/target) properties. I'm not sure if this issue will be fixed in the stable release of iOS 18.2, so in the meantime, this PR implements a workaround to avoid this issue. Fixes flutter#158299 Fixes flutter#155987
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
…#56949) These changes are mainly things I missed in flutter/engine#56719 Fixes flutter#159804
auto-submit bot pushed a commit that referenced this pull request Jan 9, 2025
…OS Safari 18.2 (#56719) (#56903) Manual cherry pick for #56719 Cherrypick request: flutter/flutter#159691
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In iOS 18.2, Safari added support for the
getCoalescedEventsAPI.That being said, the API seems to be incomplete (or at least doesn't match other browsers' behavior). The coalesced events lack a
pointerIdandtargetproperties.I'm not sure if this issue will be fixed in the stable release of iOS 18.2, so in the meantime, this PR implements a workaround to avoid this issue.
Fixes flutter/flutter#158299
Fixes flutter/flutter#155987