This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[CP-stable]Add xcprivacy privacy manifest to macOS framework #55366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Create a `PrivacyInfo.xcprivacy` (this name is required) plist and move it to the top-level of the macOS framework bundle. `NSPrivacyTracking*` and `NSPrivacyCollectedDataTypes` keys are required, but the values are blank. macOS explicitly does not need the `NSPrivacyAccessedAPITypes` (see more info in flutter/flutter#143381) You can see on this PR it's copied to the correct path in the framework https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8737163270670636097/+/u/Global_generators/Release-FlutterMacOS.framework/stdout: ``` adding: FlutterMacOS.xcframework/macos-arm64_x86_64/FlutterMacOS.framework/PrivacyInfo.xcprivacy (deflated 35%) ``` There's no way to test this except to submit a macOS app with this framework to TestFlight. I can't find a good spot in the engine to validate the structure of the framework output. I hereby pledge to add a macOS test to the framework post-roll flutter/flutter#155189 � iOS framework variant of this PR flutter#48951 Fixes flutter/flutter#131494 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
flutteractionsbot added the cp: review | @jmagman please fill out the PR description above, afterwards the release team will review this request. |
This was referenced Sep 23, 2024
stuartmorgan-g approved these changes Sep 23, 2024
jmagman suggested changes Oct 18, 2024
jmagman approved these changes Oct 23, 2024
cbracken approved these changes Oct 23, 2024
reidbaker added the autosubmit 
auto-submit bot merged commit db49896 into flutter:flutter-3.24-candidate.0 26 checks passed
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 24, 2024
#155556) This is the framework-side test for flutter/engine#55366. This test will fail unless it is run on a roll containing that fix. ### Issue Link: #154915 ### Changelog Description: Test that a built macOS app contains the FlutterMacOS framework privacy manifest and validates flutter/engine#55366. ### Impact Description: Adds confidence the Flutter macOS engine framework contains the expected privacy manifest at the right path. ### Workaround: N/A ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: Run the flutter_tool tests
LVLVirginiaLombardi added a commit to LVLVirginiaLombardi/Brainwave_Matrix_Intern that referenced this pull request Nov 3, 2024
…t (#155556) This is the framework-side test for flutter/engine#55366. This test will fail unless it is run on a roll containing that fix. ### Issue Link: flutter/flutter#154915 ### Changelog Description: Test that a built macOS app contains the FlutterMacOS framework privacy manifest and validates flutter/engine#55366. ### Impact Description: Adds confidence the Flutter macOS engine framework contains the expected privacy manifest at the right path. ### Workaround: N/A ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: Run the flutter_tool tests First Commit, creating button
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Issue Link:
flutter/flutter#154915
Changelog Description:
Comply with the new Apple privacy manifest policy for the macOS Flutter engine framework and prevent the "Missing privacy manifest" warning when submitting a macOS app to the App Store.
Impact Description:
The macOS App Store will start enforcing privacy manifests for third-party SDKs starting November 12, 2024. This change adds an empty privacy manifest to the Flutter engine FlutterMacOS.framework to comply with this new policy and prevents the warning.
Workaround:
Add an empty PrivacyInfo.xcprivacy plist to FlutterMacOS.framework and re-codesign it manually.
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
A test was added to the framework, which should also be cherry-picked flutter/flutter#155556.
While we can confirm the expected file is present, only a TestFlight/App Store submission will confirm the warning is gone.
Validation Steps:
Submit a Flutter macOS app to TestFlight or the App Store. Confirm there is no submission warning email sent.