Skip to content

Conversation

martijn00
Copy link
Contributor

@martijn00 martijn00 commented Jul 27, 2024

Connection with issue(s)

Close #120

Solution description

I cannot reproduce that min and max are switched.

Screenshots or Videos

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme
Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.02%. Comparing base (da39169) to head (4f55489).

Additional details and impacted files
@@ Coverage Diff @@ ## main #123 +/- ## ========================================== + Coverage 95.00% 95.02% +0.01%  ========================================== Files 92 92 Lines 1002 1006 +4 ========================================== + Hits 952 956 +4  Misses 50 50 
Flag Coverage Δ
unittests 95.02% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martijn00
Copy link
Contributor Author

@deandreamatias this can be merged. I'll rebase my other PR after this is merged.

@martijn00 martijn00 mentioned this pull request Jul 28, 2024
5 tasks
@martijn00
Copy link
Contributor Author

@deandreamatias any other feedback?

@deandreamatias deandreamatias merged commit 96225d7 into flutter-form-builder-ecosystem:main Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants