Add some features and more tests

[martijn00]

Connection with issue(s)

Solution description

I've added a bunch of tests. There are some issues with null checks etc that should be fixed.

Screenshots or Videos

To Do

• Read contributing guide
• Check the original issue to confirm it is fully satisfied
• Add solution description to help guide reviewers
• Add unit test to verify new or fixed behaviour
• If apply, add documentation to code properties and package readme

[deandreamatias]

Maybe in this MR can add the think that I commented here #101 (review)

Validate a lot the all validators, is something important before publish a new version

[martijn00]

@deandreamatias I can look into faker_dart but for now would first like to implement the current tests and get a release out. Are you adding it in #104 ?

[deandreamatias]

We can add the two things.
My idea is implementing in #104

[martijn00]

@deandreamatias I've done a couple of fixes but one thing i notice is inconsistency in handling null and '' string checks. In general should a empty string or null value pass a validation? I would think not? But in all the older code it does.

What is your opinion?

[martijn00]

@deandreamatias This one is finished now. I would prefer to refactor the inconsistency in handling null and '' and bump the whole release to a v11 with the breaking changes. If that is ok for you i'll make a new PR for that.

[deandreamatias]

You can define macro templates for regex (lib/src/utils/validators.dart) and add to validator dart doc to give more context

Example:

/// {@template hex_template} /// This regex match with ///  /// - Starts with a # character. /// - Is followed by exactly six characters, each of which is a hexadecimal digit (0-9, a-f, or A-f). /// - Has no additional characters before or after this pattern. ///  /// Examples: #1a2b3c and #ABCDEF /// {@endtemplate} RegExp _hex = RegExp(r'^#[0-9a-fA-F]{6}$')

/// {@macro hex_template} static FormFieldValidator<String> colorCode({

[deandreamatias]

@martijn00 I don't know if empty string or null should be pass on validation. Maybe not.
I will take a look on code to understand better this behavior

[deandreamatias]

Remember to use all templates create, like macro on validators

/// {@macro hex_template} static FormFieldValidator<String> colorCode({

[martijn00]

@deandreamatias thanks! I'll have a look at the null checks next. In general I think the behaviour should be that if a value is null or empty it should show the error message, right?