Skip to content

Conversation

martijn00
Copy link
Contributor

Connection with issue(s)

Close #???

Connected to #???

Solution description

Screenshots or Videos

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme
Copy link
Contributor

@deandreamatias deandreamatias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember about a uppercase and lowercase validation to take in account on uppercaseCharLength and lowercaseCharLength regex. Maybe on _alphabetical regex too.

https://github.com/mrmilu/flutter_mrmilu/blob/03fa62cb531b52237b9d035c48654b4ac286136e/lib/src/validators/password_validators.dart#L4

@martijn00 martijn00 requested a review from deandreamatias May 27, 2024 07:41
@deandreamatias deandreamatias merged commit b072102 into flutter-form-builder-ecosystem:main May 27, 2024
@martijn00
Copy link
Contributor Author

@deandreamatias Nice! Can you make the new release? Can't wait to try it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants