Skip to content

Fix Tuple type hint #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix Tuple type hint #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix Tuple type hint 
The type hint for the probe async coroutine definition was 'tuple' instead of 'Tuple'. This caused python 3.8.10 to fail to compile the code.
  • Loading branch information
@PhillSimonds
PhillSimonds authored Oct 15, 2021
commit ac2e80cf0e35afa5eafbd08969d76e5786fcc513
3 changes: 2 additions & 1 deletion 21-async/domains/asyncio/blogdom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,12 @@
import asyncio
import socket
from keyword import kwlist
from typing import Tuple

MAX_KEYWORD_LEN = 4 # <1>


async def probe(domain: str) -> tuple[str, bool]: # <2>
async def probe(domain: str) -> Tuple[str, bool]: # <2>
loop = asyncio.get_running_loop() # <3>
try:
await loop.getaddrinfo(domain, None) # <4>
Expand Down