Add ZstdCompressor to S3 Plugin and Fix Tests According to Maintainer's Feedback #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: yongwoo.kim <yongwoo.kim@yongwoo.kim>
Signed-off-by: yongwoo.kim <yongwoo.kim@yongwoo.kim>
Signed-off-by: ddukbg <wowrebong@gmail.com>
Before: - name: Install dependencies run: gem install bundler rake After: - name: Install dependencies run: gem install rake Signed-off-by: ddukbg <wowrebong@gmail.com>
Signed-off-by: ddukbg <wowrebong@gmail.com>
…mments Moved ZstdCompressor tests from test_in_s3.rb to test_out_s3.rb as they relate to the out_s3 plugin. Signed-off-by: ddukbg <wowrebong@gmail.com>
…omments Added tests for ZstdCompressor to test_out_s3.rb following the maintainer's suggestions. Signed-off-by: ddukbg <wowrebong@gmail.com>
Contributor Author
| Oh, I mistakenly submitted the PR incorrectly. I accidentally submitted the wrong PR. I'm working on PR#439. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This Pull Request addresses the maintainer's feedback regarding the addition of the
ZstdCompressorto the S3 output plugin.Changes Made:
Removed Duplicate
ZstdCompressorClass:lib/fluent/plugin/s3_compressor_zstd.rbas theZstdCompressorclass was already defined inout_s3.rb, eliminating duplication.Added Tests for
ZstdCompressorintest_out_s3.rb:ZstdCompressorfromtest_in_s3.rbtotest_out_s3.rbsince they pertain to the output plugin.test_configure_with_mime_type_zstdandtest_write_with_zstdto verify the proper functioning ofZstdCompressor.Ensured
ZstdCompressoris Properly Registered:ZstdCompressoris correctly registered in theCOMPRESSOR_REGISTRYwithinout_s3.rb.Fixed Test Failures:
s3pathintest_write_with_zstdto match the expected file extension for zstd compression, resolving the test failure.Resolved Gem Build Error:
s3_compressor_zstd.rbfrom the Git index to fix the gem build error caused by the file being listed but not present.Notes:
Please review the changes, and let me know if any further adjustments are needed.