fix some clippy warnings #218
Open
+456 −79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
marvin-j97 approved these changes Dec 9, 2025
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
marvin-j97 reviewed Dec 10, 2025
| | ||
| #[expect( | ||
| clippy::cast_possible_truncation, | ||
| reason = "truncation is not expected to happen" |
Contributor
There was a problem hiding this comment.
A lot of these reasonings are basically stating the obvious, but, for example, in this case, really the reasoning is: there cannot be a filter that is 4 GiB in size (on 32 bit targets) - filters of a single table never even approach multiple megabytes in size typically.
marvin-j97 reviewed Dec 10, 2025
marvin-j97 reviewed Dec 10, 2025
Remove dead code expectation from consume_writer function.
Remove dead code expectation for Indexed struct.
Removed unnecessary Clippy expect annotation for truncation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.