fix: FIR-45354 Add null suffix to Firebolt types #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bogdantruta-firebolt force-pushed the FIR-45354-add-all-firebolt-types-tests-to-node-sdk branch from 796ce41 to cdbd9de Compare 
ptiurin reviewed May 16, 2025
stepansergeevitch approved these changes May 19, 2025
Collaborator
stepansergeevitch left a comment
stepansergeevitch left a comment There was a problem hiding this comment.
LGTM, a couple of comments
|
bogdantruta-firebolt deleted the FIR-45354-add-all-firebolt-types-tests-to-node-sdk branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As mentioned by @stepansergeevitch here: Streaming PR comment, there are some differences in typing between normal queries and streamed ones. The normal aliasing worked, but not for nullable types, which defaulted to the value provided in the response (i.e.
numeric nullinstead ofdecimal null).This behavior was present for other types as well, but since the change to 2.0, it was not noticable because of having the fallback to the actual response type (as was the mapping already).
This PR aims to correct the type mapping while also fixing the null keyword from complex types (in the current implementation it is being dropped)