Skip to content

Conversation

@ptiurin
Copy link
Contributor

@ptiurin ptiurin commented Jul 11, 2024

version 16 is the earliest supported by us.
22 is the latest "current" version.
Odd numbered versions are not included as they have no long-term support.
More info - https://nodejs.org/en/about/previous-releases

@ptiurin ptiurin marked this pull request as ready for review July 11, 2024 15:20
@ptiurin ptiurin requested a review from a team as a code owner July 11, 2024 15:20
Copy link
Collaborator

@stepansergeevitch stepansergeevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it another look and it looks like we report node>=12 in package.json. Let's add 12 here as well

@ptiurin
Copy link
Contributor Author

ptiurin commented Jul 17, 2024

Gave it another look and it looks like we report node>=12 in package.json. Let's add 12 here as well

12's been so deprecated even GH forces you to use actions that are built on higher version of node.
We're also saying in the readme that our earliest version is >=14, which is inconsistent. Frankly neither are even maintained according to the docs. IMO we should deprecate everything until 18.

@ptiurin ptiurin merged commit 27248a5 into main Jul 17, 2024
@ptiurin ptiurin deleted the ci-add-nightly branch July 17, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants