Update iOSTargetOSVersionString to 11.0 #1316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
chkuang-g reviewed Jan 17, 2023
| m_Bits: 238 | ||
| iPhoneSdkVersion: 988 | ||
| iOSTargetOSVersionString: 10.0 | ||
| iOSTargetOSVersionString: 11.0 |
There was a problem hiding this comment.
I kind of feel that we should remove this line and use whatever default value for given Unity version.
- We should make sure that Firebase Unity SDK + EDM4U works with a freshly created Unity project in any given Unity version.
- Ppl who downloaded this testapp maybe using older version of Unity SDK which only required iOS SDK
10.0. - Updating value here for the test project kind of hide the potential issue in
Dependencies.xmlor perhaps bugs in EDM4U...
On the other hand, I think this is ok as a temporary workaround to make our GHA green before we fixes Dependencies.xml and release it.
There was a problem hiding this comment.
The GHA is not affected since CI is not pulling this repo for testing. This is to reduce the breakage and confusion when developers are using this repo as the start app. And the long run fix is already tracked as an issue.
chkuang-g approved these changes Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.