Skip to content

Conversation

@chinedufn
Copy link

Quickly addresses #109, but a better solution would be to warn the user if they're using RSA and we don't see any new lines in their private key.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.
1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.
@bshaffer
Copy link
Collaborator

@chinedufn you need to sign the CLA before we can merge this

@chinedufn
Copy link
Author

cool - signed

@bshaffer bshaffer merged commit 8becb3b into firebase:master Jun 22, 2017
@chinedufn chinedufn deleted the newline-warning branch June 22, 2017 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants