feat(js): Add telemetry server stream endpoint and Update tools server #3801
+2,145 −153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
huangjeff5 commented Nov 13, 2025
huangjeff5 commented - Added a streaming endpoint for retrieving a trace's spans
- Added HTTP-based runAction endpoint for streaming chunks in tools server
huangjeff5 commented Nov 20, 2025
huangjeff5 commented Nov 20, 2025
huangjeff5 commented Nov 20, 2025
huangjeff5 commented Nov 20, 2025
huangjeff5 commented Dec 3, 2025
pavelgj reviewed Dec 12, 2025
pavelgj reviewed Dec 12, 2025
| if (response.headers['x-genkit-version']) { | ||
| resp.genkitVersion = response.headers['x-genkit-version']; | ||
| | ||
| const earlyTraceId = response.headers['x-genkit-trace-id']; |
Collaborator
There was a problem hiding this comment.
super nit: is it important to call this early*? why not just traceId?
pavelgj reviewed Dec 12, 2025
| : undefined; | ||
| | ||
| const result = await manager.runAction( | ||
| { key, input, context, runtimeId }, |
Collaborator
There was a problem hiding this comment.
there's also telemetryLabels... but I wonder, might as well just pass req.body as RunActionRequest here?
pavelgj reviewed Dec 12, 2025
| | ||
| const result = await manager.runAction( | ||
| { key, input, context }, | ||
| { key, input, context, runtimeId }, |
Collaborator
There was a problem hiding this comment.
same here.: either add telemetryLabels or req.body as RunActionRequest
pavelgj reviewed Dec 12, 2025
| .openapi('TraceData'); | ||
| export type TraceData = z.infer<typeof TraceDataSchema>; | ||
| | ||
| export const SpantEventBaseSchema = z.object({ |
pavelgj reviewed Dec 12, 2025
pavelgj reviewed Dec 12, 2025
pavelgj reviewed Dec 12, 2025
pavelgj reviewed Dec 12, 2025
pavelgj reviewed Dec 12, 2025
pavelgj reviewed Dec 12, 2025
pavelgj reviewed Dec 12, 2025
pavelgj approved these changes Dec 12, 2025
Co-authored-by: Pavel Jbanov <pavelj@google.com>
Co-authored-by: Pavel Jbanov <pavelj@google.com>
Co-authored-by: Pavel Jbanov <pavelj@google.com>
Co-authored-by: Pavel Jbanov <pavelj@google.com>
Co-authored-by: Pavel Jbanov <pavelj@google.com>
Co-authored-by: Pavel Jbanov <pavelj@google.com>
Co-authored-by: Pavel Jbanov <pavelj@google.com>
…o jh-telemetry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.