Skip to content

Conversation

pavelgj
Copy link
Contributor

@pavelgj pavelgj commented Apr 25, 2022

No description provided.

Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pavel!

@egilmorez egilmorez requested a review from jhuleatt April 25, 2022 22:01
Copy link
Collaborator

@jhuleatt jhuleatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @pavelgj! The sample itself looks good to me, just two requests:

  1. Please target this PR against the gen2 branch and move it to the 2nd-gen folder. You can use this PR: #968 as a template

  2. Please add a brief README. You can use this as a template:

Firebase Custom Events sample ================================================ (short description) Getting Started --------------- (install the resize-images extension, deploy the function, etc) License ------- © Google, 2022. Licensed under an [Apache-2](../../../LICENSE) license.
@pavelgj pavelgj changed the base branch from main to gen2 April 26, 2022 18:54
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pavel! This works for me as/is with the two snippet blocks.

As shown in our internal draft, this means hard-coding the non-default example, but that's OK with me if it's OK with Jeff.

@jhuleatt
Copy link
Collaborator

jhuleatt commented May 3, 2022

Thanks Pavel! This works for me as/is with the two snippet blocks.

As shown in our internal draft, this means hard-coding the non-default example, but that's OK with me if it's OK with Jeff.

Since all that changes are the options passed to the functions, I think it's ok to hard-code.

@jhuleatt
Copy link
Collaborator

jhuleatt commented May 3, 2022

Since @egilmorez and I have approved and @peterfriese's comment is addressed, I'm going to merge this. Thank you Pavel!!

@jhuleatt jhuleatt merged commit 43b4b57 into firebase:gen2 May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants