- Notifications
You must be signed in to change notification settings - Fork 3.9k
Update Stripe Sample #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Stripe Sample #728
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it. |
@jhuleatt any idea what's going wrong here? It looks like the bot doesn't like the merging in of the changes from master. Any idea why that is? |
It looks like the CLA bot is confused. I'm going to manually set the CLA label |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
Added some small comments, but looks good to me overall! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I tried to run this on my own project, I got the error No such setupintent
after I tried to add a card
Here's the full error (line 208 in app.js):
{ code: "resource_missing" doc_url: "https://stripe.com/docs/error-codes/resource-missing" message: "No such setupintent: <redacted>" param: "intent" type: "invalid_request_error" }
My user does have a customer_id
and a setup_secret
in the database
My site is https://jeff-test-699d3.web.app/ if you'd like to try signing in and see if you run into the same thing
Thanks a mill for the review, I'll look into the needed changes :) Regarding the To help others avoid this mistake, do you remember where you copied the publishable key from? |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Thanks Thor, that was it! I copy + pasted from a draft update of this page that will go along with this PR, and forgot to replace the default key with my own. I'll make a note on the draft to use something like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for overhauling this sample, @thorsten-stripe !
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
Change to node 10 engineYou can test it here: https://cloud-functions-stripe-sample.web.app/