Skip to content

Conversation

thorsten-stripe
Copy link
Contributor

@thorsten-stripe thorsten-stripe commented May 31, 2020

  • Update to new Stripe Payments APIs and Stripe Elements
  • Change to Vanilla HTML and JavaScript
  • Update Stripe libraries
  • Change to node 10 engine

You can test it here: https://cloud-functions-stripe-sample.web.app/

  • no 3D Secure required: 4242424242424242
  • 3D Secure required: 4000000000003220
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jhuleatt jhuleatt self-requested a review June 1, 2020 16:29
@jhuleatt jhuleatt self-assigned this Jun 1, 2020
@thorsten-stripe
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jun 4, 2020
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Jun 4, 2020
@thorsten-stripe
Copy link
Contributor Author

@googlebot I fixed it.

@thorsten-stripe
Copy link
Contributor Author

@jhuleatt any idea what's going wrong here? It looks like the bot doesn't like the merging in of the changes from master. Any idea why that is?

@jhuleatt
Copy link
Collaborator

It looks like the CLA bot is confused. I'm going to manually set the CLA label

@jhuleatt jhuleatt added cla: yes and removed cla: no labels Jun 12, 2020
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@jhuleatt
Copy link
Collaborator

Added some small comments, but looks good to me overall!

Copy link
Collaborator

@jhuleatt jhuleatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tried to run this on my own project, I got the error No such setupintent after I tried to add a card

Here's the full error (line 208 in app.js):

{ code: "resource_missing" doc_url: "https://stripe.com/docs/error-codes/resource-missing" message: "No such setupintent: <redacted>" param: "intent" type: "invalid_request_error" }

My user does have a customer_id and a setup_secret in the database

My site is https://jeff-test-699d3.web.app/ if you'd like to try signing in and see if you run into the same thing

@thorsten-stripe
Copy link
Contributor Author

Thanks a mill for the review, I'll look into the needed changes :)

Regarding the No such setupintent error, it looks like you're using the default publishable key from the Stripe docs, rather than your Stripe account's publishable key. Updating the STRIPE_PUBLISHABLE_KEY in the app.js file with the one in your Stripe Dashboard should do the trick 👍

To help others avoid this mistake, do you remember where you copied the publishable key from?

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@jhuleatt
Copy link
Collaborator

Thanks a mill for the review, I'll look into the needed changes :)

Regarding the No such setupintent error, it looks like you're using the default publishable key from the Stripe docs, rather than your Stripe account's publishable key. Updating the STRIPE_PUBLISHABLE_KEY in the app.js file with the one in your Stripe Dashboard should do the trick 👍

To help others avoid this mistake, do you remember where you copied the publishable key from?

Thanks Thor, that was it! I copy + pasted from a draft update of this page that will go along with this PR, and forgot to replace the default key with my own. I'll make a note on the draft to use something like <YOUR STRIPE PUBLISHABLE KEY> instead of the default publishable key.

Copy link
Collaborator

@jhuleatt jhuleatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for overhauling this sample, @thorsten-stripe !

@jhuleatt jhuleatt added cla: yes and removed cla: no labels Jun 15, 2020
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants