Skip to content

Conversation

@LloydVincent
Copy link
Contributor

Playing around with this code, it seems exports.api links the path to "/api" automatically, it's redundant to add it in the get/post path and causes the url to fail.

Playing around with this code, it seems ```exports.api``` links the path to "/api" automatically, it's redundant to add it in the get/post path and causes the url to fail.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.
@LloydVincent
Copy link
Contributor Author

I signed it

@googlebot
Copy link

CLAs look good, thanks!

@nicolasgarnier
Copy link
Contributor

Thanks @LloydVincent that's right, the 'api' prefix was never needed :)

@nicolasgarnier nicolasgarnier merged commit fab4e33 into firebase:master Sep 1, 2017
@LloydVincent LloydVincent deleted the patch-1 branch September 19, 2017 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants