Add paypal-rest-sdk sample #151

Kevded · 2017-05-18T00:21:03Z

Use Paypal-rest-sdk on firebase functions
paypal-rest-sdks

nicolasgarnier

Thanks so much for this sample @Kevded , it's a nice one! I have added a few comments, would be nice if you could resolve them!

Cheers!

nicolasgarnier · 2017-05-30T09:16:39Z

paypal/functions/index.js

+// Configure your environment
+paypal.configure({
+ 'mode': 'sandbox', // sandbox or live
+ 'client_id': 'your_client_id', // replace your_client_id


Could you replace 'your_cliend_id' by functions.config().paypal.client_id and add instrucitons to set this environment variable in the README (i.e. users have to run: firebase functions:config:set paypal.client_id="yourPaypalClientID" paypal.client_secret="yourPaypalClientSecret")?

nicolasgarnier · 2017-05-30T09:16:54Z

paypal/functions/index.js

+paypal.configure({
+ 'mode': 'sandbox', // sandbox or live
+ 'client_id': 'your_client_id', // replace your_client_id
+ 'client_secret': 'your_client_secret' // replace your_client_secret


Could you replace 'your_cliend_id' by functions.config().paypal.client_secret ?

nicolasgarnier · 2017-05-30T09:18:23Z

paypal/functions/index.js

+ res.setHeader('Content-Type', 'application/json');
+ res.setHeader('Access-Control-Allow-Origin', '*');
+ res.setHeader('Access-Control-Allow-Headers', 'application/json, Content-Type');
+ res.setHeader('Access-Control-Allow-Methods', 'POST');


Could you use the cors ExpressJS middleware here instead of setting all the headers manually? See an example here: https://github.com/firebase/functions-samples/blob/master/quickstarts/time-server/functions/index.js#L57

nicolasgarnier · 2017-05-30T09:18:52Z

paypal/functions/index.js

+ 'client_secret': 'your_client_secret' // replace your_client_secret
+});
+
+exports.pay = functions.https.onRequest((req, res) => {


Can you add some comment above explaining what the Functions does?

nicolasgarnier · 2017-05-30T09:23:47Z

paypal/functions/index.js

+ // example url https://us-central1-<project-id>.cloudfunctions.net/process
+ // replace return_url, cancel_url
+ redirect_urls: {
+ return_url: 'https://us-central1-<project-id>.cloudfunctions.net/process',


You can get the project ID from: process.env.GCLOUD_PROJECT so please replace with:

return_url: `https://us-central1-${process.env.GCLOUD_PROJECT}.cloudfunctions.net/process`,

nicolasgarnier · 2017-05-30T13:05:33Z

paypal/functions/index.js

+ payer_id: req.query.PayerID
+ };
+
+ paypal.payment.execute(paymentId, payerId, function (error, payment) {


Use an arrow function here :)

nicolasgarnier · 2017-05-30T13:05:54Z

paypal/functions/index.js

+
+ paypal.payment.execute(paymentId, payerId, function (error, payment) {
+ if (error) {
+ console.error(JSON.stringify(error));


just console.error(error);

nicolasgarnier · 2017-05-30T13:06:15Z

paypal/functions/index.js

+ paypal.payment.execute(paymentId, payerId, function (error, payment) {
+ if (error) {
+ console.error(JSON.stringify(error));
+ res.redirect('http://localhost:4200/error');


Change that URL to a production URL ?

nicolasgarnier · 2017-05-30T13:06:51Z

paypal/functions/index.js

+ } else {
+ console.warn('payment.state: not approved ?');
+ // replace debug url
+ res.redirect('https://console.firebase.google.com/project/<project-id>/functions/logs?search=&severity=DEBUG');


You can replace the project ID automatically here as shown above.

nicolasgarnier · 2017-05-30T13:07:47Z

paypal/functions/index.js

+});
+
+// Complete the payment
+exports.process = functions.https.onRequest((req, res) => {


Could you add a little bit more details in the comment here to explain a bit more what this function does?

nicolasgarnier · 2017-06-29T12:24:08Z

ping :)

Kevded · 2017-06-29T16:51:36Z

I work on it.

nicolasgarnier · 2017-07-03T15:30:13Z

Thanks @Kevded I've updated the README with more detailed step-by-step instructions.

Do you think it would be possible for you to also commit a small web UI like the one you showed in the animated GIF? this would make the sample so much more complete! PS if you do don't forget about this feature: https://firebase.google.com/docs/hosting/functions this will allow you to have the Paypal Cloud Function on the same domain as the web UI.

Kevded · 2017-07-21T07:35:29Z

I tried to pass the uid value via the optional "custom" field in the "transaction" object as in paypal https://developer.paypal.com/docs/api/payments/#definition-transaction, but this does not work, so I have passed through the "description" field.

nicolasgarnier · 2017-07-03T15:24:01Z

paypal/functions/.eslintrc.js

@@ -0,0 +1,3 @@
+module.exports = {
+ "extends": "google"
+};


Could you remove that file fro the PR?

nicolasgarnier · 2017-07-03T15:24:13Z

paypal/functions/.eslintrc.json

+ "constructor-super": "warn",
+ "valid-typeof": "warn"
+ }
+}


Could you remove that file from the PR ?

nicolasgarnier · 2017-07-03T15:24:31Z

paypal/functions/.jshintrc

+
+ // Custom Globals
+ "globals" : {} // additional predefined global variables
+}


Could you remove that file from the PR?

nicolasgarnier · 2017-07-03T15:24:35Z

paypal/functions/=3.8.1

+paypal-functions@ /home/dsv/WebstormProjects/functions-samples/paypal/functions
+├── eslint@4.1.1 
+└── eslint-config-google@0.8.0 
+


Could you remove that file from the PR?

nicolasgarnier · 2017-07-03T15:25:20Z

paypal/functions/index.js

@@ -0,0 +1,102 @@
+'use strict';


Can you add a LICNCE header here please? Example: https://github.com/firebase/functions-samples/blob/master/assistant-say-number/functions/index.js#L1-L16

nicolasgarnier · 2017-07-03T15:25:56Z

paypal/functions/index.js

+ 'client_secret': functions.config().paypal.client_secret // run: firebase functions:config:set paypal.client_secret="yourPaypalClientSecret"
+});
+
+exports.pay = functions.https.onRequest((req, res) => {


Could you add a commenbt describing what the function does, what is expected as body in the request etc...

nicolasgarnier · 2017-07-03T15:26:15Z

paypal/functions/index.js

+
+exports.pay = functions.https.onRequest((req, res) => {
+ // Dev
+ cors(req, res, () => {});


nicolasgarnier · 2017-07-03T15:26:39Z

paypal/functions/index.js

+ }
+ }
+ });
+});


Add line at the end of the file.

nicolasgarnier · 2017-07-03T15:27:31Z

paypal/functions/package.json

+ "description": "Paypal Firebase Functions",
+ "dependencies": {
+ "cors": "^2.8.3",
+ "eslint": "^4.1.1",


can you remove eslint stuff from dependency and devDependency?

nicolasgarnier · 2017-07-21T09:32:35Z

paypal/public/success.html

+ <a disabled class="mdl-button mdl-js-button mdl-button--raised" href="/">Home</a>
+</body>
+
+</html>


Can you please add a trailing line at the end of the file ? :)

nicolasgarnier · 2017-07-21T09:34:12Z

paypal/public/index.html

+ </div>
+</body>
+
+</html>


Please add a line at the end of the file.

nicolasgarnier · 2017-10-04T15:36:15Z

I added a few style fixes and we should be all set :)

Kevded and others added 10 commits May 17, 2017 10:09

Create README.md

92b7498

create index.js

0994907

create firebase.json

1e494ab

create package.json

f53f8c9

create demo.gif

7228a3f

maj

fbf8ed4

Update README.md

2fa9848

Update README.md

4ca547d

Update index.js

dc8dcb2

Update README.md

0904e75

nicolasgarnier suggested changes May 30, 2017

View reviewed changes

nicolasgarnier self-assigned this Jun 29, 2017

Kevded and others added 7 commits June 29, 2017 15:02

Update

22ba38c

Update comments, cors

819dd59

Update

97cf9ec

Update README.md

1dbc8a4

Update README.md

3b8dd93

Update README.md

94fcc3f

Update to the readme with more instructions.

036872b

Kevded added 3 commits July 18, 2017 21:09

Add demo

9746b36

Update

21bb79a

Update

88ac686

nicolasgarnier reviewed Jul 21, 2017

View reviewed changes

nicolasgarnier reviewed Jul 24, 2017

View reviewed changes

Kevded and others added 2 commits August 1, 2017 19:45

Update

b832b43

Indent fixes

65d7f56

nicolasgarnier added 5 commits October 4, 2017 17:31

style fixes and made URLs generic

70903e5

Added process URL

96c93ea

Added EOF Line break

e0164e7

Added EOF Line break

df2dcb5

Updated Firebase SDK versions

cea1578

nicolasgarnier approved these changes Oct 4, 2017

View reviewed changes

nicolasgarnier merged commit 24672ea into firebase:master Oct 4, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add paypal-rest-sdk sample #151

Add paypal-rest-sdk sample #151

Uh oh!

Kevded commented May 18, 2017

nicolasgarnier left a comment •

edited

Loading

nicolasgarnier May 30, 2017

nicolasgarnier May 30, 2017

nicolasgarnier May 30, 2017

nicolasgarnier May 30, 2017

nicolasgarnier May 30, 2017

nicolasgarnier May 30, 2017

nicolasgarnier May 30, 2017

nicolasgarnier May 30, 2017

nicolasgarnier May 30, 2017

nicolasgarnier May 30, 2017

nicolasgarnier commented Jun 29, 2017

Kevded commented Jun 29, 2017 via email •

edited

Loading

nicolasgarnier commented Jul 3, 2017

Kevded commented Jul 21, 2017

nicolasgarnier Jul 3, 2017

nicolasgarnier Jul 3, 2017

nicolasgarnier Jul 3, 2017

nicolasgarnier Jul 3, 2017

nicolasgarnier Jul 3, 2017

nicolasgarnier Jul 3, 2017

nicolasgarnier Jul 3, 2017

nicolasgarnier Jul 3, 2017

nicolasgarnier Jul 3, 2017

nicolasgarnier Jul 21, 2017

nicolasgarnier Jul 21, 2017

nicolasgarnier commented Oct 4, 2017

Labels

2 participants

+  }
+  }
+  });
+ });    No newline at end of file

+  </div>
+ </body>
+ </html>    No newline at end of file

Add paypal-rest-sdk sample #151

Add paypal-rest-sdk sample #151

Uh oh!

Conversation

Kevded commented May 18, 2017

nicolasgarnier left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicolasgarnier commented Jun 29, 2017

Kevded commented Jun 29, 2017 via email • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

nicolasgarnier commented Jul 3, 2017

Kevded commented Jul 21, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicolasgarnier commented Oct 4, 2017

Labels

2 participants

nicolasgarnier left a comment •

edited

Loading

Kevded commented Jun 29, 2017 via email •

edited

Loading