added developer motivator sample #147
Conversation
| I had to laugh at the concept of this sample. :-) |
| Not a bad idea |
There was a problem hiding this comment.
Thanks @tidoemanuele let;s go with it ;) Some comments though :)
| "dependencies": { | ||
| "firebase-admin": "^4.1.2", | ||
| "firebase-functions": "^0.5.1" } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Add new line at the end of file please :)
| "description": "A simple developer motivator using Cloud Function and firebase analytics", | ||
| "dependencies": { | ||
| "firebase-admin": "^4.1.2", | ||
| "firebase-functions": "^0.5.1" } |
There was a problem hiding this comment.
line break before the }
| @@ -0,0 +1,52 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
Need to add an Apache 2.0 Google licence header at the top of the file (see other similar files)
| } | ||
| }; | ||
| | ||
| admin.messaging().sendToDevice("put_your_developer_device_token_here", payload).then(response => { |
There was a problem hiding this comment.
You can remove the whole .then(...); section since this in order to remove the invalid/expired device tokens from the database (here we don't use the database to hold device tokens).
| } | ||
| }; | ||
| | ||
| admin.messaging().sendToDevice("put_your_developer_device_token_here", payload).then(response => { |
There was a problem hiding this comment.
You can remove the whole .then(...); section since this in order to remove the invalid/expired device tokens from the database (here we don't use the database to hold device tokens).
| const functions = require('firebase-functions'); | ||
| admin.initializeApp(functions.config().firebase); | ||
| | ||
| exports.appinstalled = functions.analytics.event('first_open').onLog(event => { |
There was a problem hiding this comment.
Could you add some short comment explaining what the functions does?
| }); | ||
| }); | ||
| | ||
| exports.appremoved = functions.analytics.event('app_remove').onLog(event => { |
There was a problem hiding this comment.
Could you add some short comment explaining what the functions does?
developer-motivator/firebase.json Outdated
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "database": { | |||
There was a problem hiding this comment.
This file can just be {} since there is no database or hosting used.
| @@ -0,0 +1,6 @@ | |||
| { | |||
There was a problem hiding this comment.
You can just remove this file since we don't use the database in this sample.
| | ||
| ## Trigger rules | ||
| | ||
| The functions triggers every time a new user open your app the first time or remove your app from his device. |
There was a problem hiding this comment.
Could you add a ## Setup and test this sample section giving a step by step process to follow in order to get the sample running, for instance the tricky part will be how to get a developper device token.
| Nice thanks! Could you add an entry to the main README.md (at the root) pointing to your sample and we should be good :) |
| All right looks good @tidoemanuele ! thanks! |
4 participants
Send Firebase Cloud Messaging each time a new user open your app the first time or remove your app from his device.