Skip to content

Remove ImageMagick from thumbnail samples (1st and 2nd gen) #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 4, 2023
Merged

Remove ImageMagick from thumbnail samples (1st and 2nd gen) #1079

merged 10 commits into from
May 4, 2023

Conversation

@jhuleatt
Copy link
Collaborator

@jhuleatt jhuleatt commented May 4, 2023

@jhuleatt jhuleatt requested a review from egilmorez May 4, 2023 18:48
@jhuleatt jhuleatt marked this pull request as ready for review May 4, 2023 19:10
egilmorez
egilmorez approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray for sharp!! Thanks!
@jhuleatt jhuleatt changed the title Remove ImageMagick from 2nd gen sample Remove ImageMagick from thumbnail samples (1st and 2nd gen) May 4, 2023
@jhuleatt jhuleatt requested a review from egilmorez May 4, 2023 19:55
egilmorez
egilmorez approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for extending to 1st gen as well!
@jhuleatt jhuleatt merged commit 9779c58 into main May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@jhuleatt @egilmorez