- Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed
Labels
Description
[REQUIRED] Describe your environment
"firebase": "^8.2.4", "firebaseui": "^4.7.1", System: OS: macOS 11.1 Binaries: Node: 14.15.4 - ~/.nvm/versions/node/v14.15.4/bin/node Yarn: 1.22.10 - /usr/local/bin/yarn npm: 6.14.11 - ~/.nvm/versions/node/v14.15.4/bin/npm Browsers: Chrome: 88.0.4324.96 Edge: Not Found Firefox: Not Found Safari: 14.0.2
[REQUIRED] Describe the problem
firebaseui dialog grows after sign-on success
Steps to reproduce:
complete sign-on w/ link, enter email address to continue (don't press enter), over mouse over script debug "pause execution button", press enter and rapidly click pause button.
Open inspector to view DOM.
Relevant Code:
firebaseui-web/stylesheet/firebase-ui.css
Lines 375 to 377 in 540ddc0
/* If we do not set height here, the default Safari dialog settings make the | |
* dialog too tall. */ | |
height: auto; |
My interim fix
dialog.mdl-dialog.firebaseui-dialog.firebaseui-id-dialog { height: fit-content !important; }
I haven't seen any side effects from overriding the height yet ~ but considering the comment already existing there ~ maybe implications elsewhere.