Provision App Hosting compute service account during init flow

CHANGELOG.md

@@ -5,3 +5,4 @@
 - Add GCP API client functions to support App Hosting deploy from source feature. (#8545)
 - Changed firebase init template for functions to pin runtime version on init. (#8553)
 - Fix an issue where updating a Cloud Function that retires would add incorrect fields to the updateMask. (#8560)
+- Provision App Hosting compute service account during init flow. (#8580)

src/apphosting/backend.ts

@@ -49,7 +49,7 @@
  // SSL.
  const maybeNodeError = err as { cause: { code: string }; code: string };
  if (
  /HANDSHAKE_FAILURE/.test(maybeNodeError?.cause?.code) ||
  "EPROTO" === maybeNodeError?.code
  ) {
  return false;
@@ -76,14 +76,7 @@
  webAppName: string | null,
  serviceAccount: string | null,
 ): Promise<void> {
- await Promise.all([
- ensure(projectId, developerConnectOrigin(), "apphosting", true),
- ensure(projectId, cloudbuildOrigin(), "apphosting", true),
- ensure(projectId, secretManagerOrigin(), "apphosting", true),
- ensure(projectId, cloudRunApiOrigin(), "apphosting", true),
- ensure(projectId, artifactRegistryDomain(), "apphosting", true),
- ensure(projectId, iamOrigin(), "apphosting", true),
- ]);
+ await ensureRequiredApisEnabled(projectId);
 
  // Hack: Because IAM can take ~45 seconds to propagate, we provision the service account as soon as
  // possible to reduce the likelihood that the subsequent Cloud Build fails. See b/336862200.
@@ -179,6 +172,20 @@
  logSuccess(`Your backend is now deployed at:\n\thttps://${backend.uri}`);
 }
 
+/**
+ * Check that all GCP APIs required for App Hosting are enabled.
+ */
+export async function ensureRequiredApisEnabled(projectId: string): Promise<void> {
+ await Promise.all([
+ ensure(projectId, developerConnectOrigin(), "apphosting", true),
+ ensure(projectId, cloudbuildOrigin(), "apphosting", true),
+ ensure(projectId, secretManagerOrigin(), "apphosting", true),
+ ensure(projectId, cloudRunApiOrigin(), "apphosting", true),
+ ensure(projectId, artifactRegistryDomain(), "apphosting", true),
+ ensure(projectId, iamOrigin(), "apphosting", true),
+ ]);
+}
+
 /**
  * Set up a new App Hosting-type Developer Connect GitRepoLink, optionally with a specific connection ID
  */
@@ -248,7 +255,7 @@
  * Prompts the user for a backend id and verifies that it doesn't match a pre-existing backend.
  */
 export async function promptNewBackendId(projectId: string, location: string): Promise<string> {
  while (true) {
  const backendId = await input({
  default: "my-web-app",
  message: "Provide a name for your backend [1-30 characters]",
@@ -546,7 +553,7 @@
  message: locationDisambugationPrompt,
  choices: [...backendsByLocation.keys()],
  });
  return backendsByLocation.get(location)!;
 }
 
 /**

src/commands/init.ts

@@ -48,7 +48,7 @@
  },
  {
  value: "apphosting",
- name: "App Hosting: Configure an apphosting.yaml file for App Hosting",
+ name: "App Hosting: Enable web app deployments with App Hosting",
  checked: false,
  hidden: false,
  },
@@ -178,7 +178,7 @@
 
  const setup: Setup = {
  config: config.src,
  rcfile: config.readProjectFile(".firebaserc", {
  json: true,
  fallback: {},
  }),

src/init/features/apphosting.ts

@@ -2,22 +2,25 @@ import * as clc from "colorette";
 import { existsSync } from "fs";
 import * as ora from "ora";
 import * as path from "path";
+import { Setup } from "..";
 import { webApps } from "../../apphosting/app";
 import {
  createBackend,
+ ensureAppHostingComputeServiceAccount,
+ ensureRequiredApisEnabled,
  promptExistingBackend,
  promptLocation,
  promptNewBackendId,
 } from "../../apphosting/backend";
 import { Config } from "../../config";
 import { FirebaseError } from "../../error";
 import { AppHostingSingle } from "../../firebaseConfig";
+import { ensureApiEnabled } from "../../gcp/apphosting";
+import { isBillingEnabled } from "../../gcp/cloudbilling";
+import { input, select } from "../../prompt";
 import { readTemplateSync } from "../../templates";
 import * as utils from "../../utils";
 import { logBullet } from "../../utils";
-import { input, select } from "../../prompt";
-import { Setup } from "..";
-import { isBillingEnabled } from "../../gcp/cloudbilling";
 
 const APPHOSTING_YAML_TEMPLATE = readTemplateSync("init/apphosting/apphosting.yaml");
 
@@ -31,6 +34,19 @@ export async function doSetup(setup: Setup, config: Config): Promise<void> {
  "Firebase App Hosting requires billing to be enabled on your project. Please enable billing by following the steps at https://cloud.google.com/billing/docs/how-to/modify-project",
  );
  }
+ await ensureApiEnabled({ projectId });
+ await ensureRequiredApisEnabled(projectId);
+ try {
+ await ensureAppHostingComputeServiceAccount(projectId, /* serviceAccount= */ "");
+ } catch (err) {
+ if ((err as FirebaseError).status === 400) {
+ utils.logWarning(
+ "Your App Hosting compute service account is still being provisioned. Please try again in a few moments.",
+ );
+ }
+ throw err;
+ }
+
  utils.logBullet(
  "This command links your local project to Firebase App Hosting. You will be able to deploy your web app with `firebase deploy` after setup.",
  );

src/init/index.ts

@@ -17,12 +17,12 @@
  featureInfo?: SetupInfo;
 
  /** Basic Project information */
  project?: Record<string, any>;
  projectId?: string;
  projectLocation?: string;
  isBillingEnabled?: boolean;
 
  hosting?: Record<string, any>;
 }
 
 export interface SetupInfo {
@@ -31,6 +31,7 @@
 
 interface Feature {
  name: string;
+ displayName?: string;
  // OLD WAY: A single setup function to ask questions and actuate the setup.
  doSetup?: (setup: Setup, config: Config, options: Options) => Promise<unknown>;
 
@@ -64,16 +65,18 @@
  { name: "remoteconfig", doSetup: features.remoteconfig },
  { name: "hosting:github", doSetup: features.hostingGithub },
  { name: "genkit", doSetup: features.genkit },
- { name: "apphosting", doSetup: features.apphosting },
+ { name: "apphosting", displayName: "App Hosting", doSetup: features.apphosting },
 ];
 
 const featureMap = new Map(featuresList.map((feature) => [feature.name, feature]));
 
 export async function init(setup: Setup, config: any, options: any): Promise<any> {
  const nextFeature = setup.features?.shift();
  if (nextFeature) {
  const f = lookupFeature(nextFeature);
- logger.info(clc.bold(`\n${clc.white("===")} ${capitalize(nextFeature)} Setup`));
+ logger.info(
+ clc.bold(`\n${clc.white("===")} ${f.displayName || capitalize(nextFeature)} Setup`),
+ );
 
  if (f.doSetup) {
  await f.doSetup(setup, config, options);