Svnsairam setup turtlestack cli #5846
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| I believe you're going to want to feature-gate this. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@ ## master #5846 +/- ## ======================================= Coverage 54.94% 54.94% ======================================= Files 339 339 Lines 23151 23151 Branches 4733 4733 ======================================= Hits 12721 12721 Misses 9303 9303 Partials 1127 1127 ☔ View full report in Codecov by Sentry. |
taeold reviewed May 22, 2023
| const projectId = setup?.rcfile?.projects?.default; | ||
| if (projectId) { | ||
| await requirePermissions({ ...options, project: projectId }); | ||
| await Promise.all([ensure(projectId, "firebaseextensions.googleapis.com", "unused", true)]); |
Contributor
There was a problem hiding this comment.
Can we add a TODO here to replace with real API later?
taeold reviewed Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Scenarios Tested
Sample Commands