[Auth] Fix double-onAuthStateChanged call bug #5686

sam-gc · 2021-10-29T18:42:56Z

changeset-bot · 2021-10-29T18:42:58Z

🦋 Changeset detected

Latest commit: 8561fc0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/auth	Patch
@firebase/auth-compat	Patch
firebase	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2021-10-29T18:58:28Z

Binary Size Report

Affected SDKs

@firebase/auth/cordova

Type Base (4594d3f) Head (c51c87f) Diff

browser 179 kB 179 kB +88 B (+0.0%)

module 179 kB 179 kB +88 B (+0.0%)
@firebase/auth/internal

Type Base (4594d3f) Head (c51c87f) Diff

browser 163 kB 163 kB +88 B (+0.1%)

esm5 211 kB 211 kB +88 B (+0.0%)

main 179 kB 179 kB +88 B (+0.0%)

module 163 kB 163 kB +88 B (+0.1%)
@firebase/auth/react-native

Type Base (4594d3f) Head (c51c87f) Diff

browser 162 kB 162 kB +88 B (+0.1%)

module 162 kB 162 kB +88 B (+0.1%)

`firebase`

Type	Base (`4594d3f`)	Head (`c51c87f`)	Diff
firebase-auth-compat.js	122 kB	122 kB	+82 B (+0.1%)
firebase-auth-cordova.js	460 kB	460 kB	+131 B (+0.0%)
firebase-auth-react-native.js	479 kB	479 kB	+131 B (+0.0%)
firebase-auth.js	410 kB	410 kB	+119 B (+0.0%)
firebase-compat.js	751 kB	751 kB	+82 B (+0.0%)

Test Logs

Base (4594d3fd): https://github.com/firebase/firebase-js-sdk/actions/runs/1392186344
Head (c51c87f3): https://github.com/firebase/firebase-js-sdk/actions/runs/1400621741

google-oss-bot · 2021-10-29T19:21:57Z

Size Analysis Report

Affected Products

@firebase/auth
- ActionCodeURL
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  30.8 kB
  30.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.9 kB
  43.0 kB
  +84 B (+0.2%)
- AuthCredential
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  30.0 kB
  30.1 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.9 kB
  42.0 kB
  +84 B (+0.2%)
- EmailAuthCredential
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  31.9 kB
  32.0 kB
  +84 B (+0.3%)
  size-with-ext-deps
  43.8 kB
  43.9 kB
  +84 B (+0.2%)
- EmailAuthProvider
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  33.3 kB
  33.4 kB
  +84 B (+0.3%)
  size-with-ext-deps
  45.5 kB
  45.5 kB
  +84 B (+0.2%)
- FacebookAuthProvider
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  34.9 kB
  35.0 kB
  +84 B (+0.2%)
  size-with-ext-deps
  46.8 kB
  46.9 kB
  +84 B (+0.2%)
- GithubAuthProvider
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  34.9 kB
  35.0 kB
  +84 B (+0.2%)
  size-with-ext-deps
  46.8 kB
  46.9 kB
  +84 B (+0.2%)
- GoogleAuthProvider
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  34.9 kB
  35.0 kB
  +84 B (+0.2%)
  size-with-ext-deps
  46.8 kB
  46.9 kB
  +84 B (+0.2%)
- OAuthCredential
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  32.0 kB
  32.1 kB
  +84 B (+0.3%)
  size-with-ext-deps
  43.9 kB
  44.0 kB
  +84 B (+0.2%)
- OAuthProvider
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  35.9 kB
  36.0 kB
  +84 B (+0.2%)
  size-with-ext-deps
  47.7 kB
  47.8 kB
  +84 B (+0.2%)
- PhoneAuthCredential
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  32.0 kB
  32.1 kB
  +84 B (+0.3%)
  size-with-ext-deps
  43.9 kB
  44.0 kB
  +84 B (+0.2%)
- PhoneAuthProvider
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  33.7 kB
  33.8 kB
  +84 B (+0.2%)
  size-with-ext-deps
  45.6 kB
  45.7 kB
  +84 B (+0.2%)
- PhoneMultiFactorGenerator
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  30.7 kB
  30.8 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.6 kB
  42.7 kB
  +84 B (+0.2%)
- RecaptchaVerifier
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  36.2 kB
  36.3 kB
  +84 B (+0.2%)
  size-with-ext-deps
  48.1 kB
  48.1 kB
  +84 B (+0.2%)
- SAMLAuthProvider
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  36.2 kB
  36.3 kB
  +84 B (+0.2%)
  size-with-ext-deps
  48.1 kB
  48.2 kB
  +84 B (+0.2%)
- TwitterAuthProvider
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  34.9 kB
  35.0 kB
  +84 B (+0.2%)
  size-with-ext-deps
  46.8 kB
  46.9 kB
  +84 B (+0.2%)
- applyActionCode
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  30.0 kB
  30.1 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.9 kB
  41.9 kB
  +84 B (+0.2%)
- checkActionCode
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  30.9 kB
  31.0 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.8 kB
  42.9 kB
  +84 B (+0.2%)
- confirmPasswordReset
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  30.0 kB
  30.1 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.9 kB
  42.0 kB
  +84 B (+0.2%)
- connectAuthEmulator
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  31.5 kB
  31.6 kB
  +84 B (+0.3%)
  size-with-ext-deps
  43.4 kB
  43.4 kB
  +84 B (+0.2%)
- createUserWithEmailAndPassword
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  30.9 kB
  31.0 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.8 kB
  42.8 kB
  +84 B (+0.2%)
- deleteUser
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  29.8 kB
  29.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.7 kB
  41.7 kB
  +84 B (+0.2%)
- fetchSignInMethodsForEmail
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  30.2 kB
  30.3 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.1 kB
  42.2 kB
  +84 B (+0.2%)
- getAdditionalUserInfo
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  31.1 kB
  31.2 kB
  +84 B (+0.3%)
  size-with-ext-deps
  43.0 kB
  43.0 kB
  +84 B (+0.2%)
- getAuth
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  61.7 kB
  61.8 kB
  +84 B (+0.1%)
  size-with-ext-deps
  74.2 kB
  74.3 kB
  +84 B (+0.1%)
- getIdToken
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  29.8 kB
  29.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.7 kB
  41.7 kB
  +84 B (+0.2%)
- getIdTokenResult
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  29.7 kB
  29.8 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.6 kB
  41.7 kB
  +84 B (+0.2%)
- getMultiFactorResolver
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  32.5 kB
  32.6 kB
  +84 B (+0.3%)
  size-with-ext-deps
  44.4 kB
  44.4 kB
  +84 B (+0.2%)
- getRedirectResult
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  37.4 kB
  37.5 kB
  +84 B (+0.2%)
  size-with-ext-deps
  49.3 kB
  49.4 kB
  +84 B (+0.2%)
- initializeAuth
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  30.0 kB
  30.1 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.2 kB
  42.3 kB
  +84 B (+0.2%)
- isSignInWithEmailLink
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  31.0 kB
  31.0 kB
  +84 B (+0.3%)
  size-with-ext-deps
  43.1 kB
  43.1 kB
  +84 B (+0.2%)
- linkWithCredential
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  30.8 kB
  30.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.7 kB
  42.7 kB
  +84 B (+0.2%)
- linkWithPhoneNumber
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  34.5 kB
  34.5 kB
  +84 B (+0.2%)
  size-with-ext-deps
  46.4 kB
  46.4 kB
  +84 B (+0.2%)
- linkWithPopup
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  41.0 kB
  41.1 kB
  +84 B (+0.2%)
  size-with-ext-deps
  52.9 kB
  53.0 kB
  +84 B (+0.2%)
- linkWithRedirect
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  36.2 kB
  36.3 kB
  +84 B (+0.2%)
  size-with-ext-deps
  48.1 kB
  48.1 kB
  +84 B (+0.2%)
- multiFactor
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  32.0 kB
  32.0 kB
  +84 B (+0.3%)
  size-with-ext-deps
  43.8 kB
  43.9 kB
  +84 B (+0.2%)
- onAuthStateChanged
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  29.8 kB
  29.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.7 kB
  41.8 kB
  +84 B (+0.2%)
- onIdTokenChanged
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  29.8 kB
  29.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.7 kB
  41.8 kB
  +84 B (+0.2%)
- parseActionCodeURL
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  30.9 kB
  31.0 kB
  +84 B (+0.3%)
  size-with-ext-deps
  43.0 kB
  43.1 kB
  +84 B (+0.2%)
- reauthenticateWithCredential
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  31.4 kB
  31.4 kB
  +84 B (+0.3%)
  size-with-ext-deps
  43.2 kB
  43.3 kB
  +84 B (+0.2%)
- reauthenticateWithPhoneNumber
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  35.0 kB
  35.1 kB
  +84 B (+0.2%)
  size-with-ext-deps
  46.9 kB
  47.0 kB
  +84 B (+0.2%)
- reauthenticateWithPopup
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  41.0 kB
  41.1 kB
  +84 B (+0.2%)
  size-with-ext-deps
  52.9 kB
  53.0 kB
  +84 B (+0.2%)
- reauthenticateWithRedirect
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  35.9 kB
  36.0 kB
  +84 B (+0.2%)
  size-with-ext-deps
  47.8 kB
  47.9 kB
  +84 B (+0.2%)
- reload
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  29.7 kB
  29.8 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.6 kB
  41.7 kB
  +84 B (+0.2%)
- sendEmailVerification
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  30.8 kB
  30.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.7 kB
  42.8 kB
  +84 B (+0.2%)
- sendPasswordResetEmail
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  30.7 kB
  30.8 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.6 kB
  42.7 kB
  +84 B (+0.2%)
- sendSignInLinkToEmail
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  30.8 kB
  30.8 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.6 kB
  42.7 kB
  +84 B (+0.2%)
- setPersistence
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  29.8 kB
  29.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.7 kB
  41.7 kB
  +84 B (+0.2%)
- signInAnonymously
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  31.0 kB
  31.1 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.9 kB
  43.0 kB
  +84 B (+0.2%)
- signInWithCredential
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  31.1 kB
  31.2 kB
  +84 B (+0.3%)
  size-with-ext-deps
  43.0 kB
  43.1 kB
  +84 B (+0.2%)
- signInWithCustomToken
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  30.9 kB
  31.0 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.8 kB
  42.8 kB
  +84 B (+0.2%)
- signInWithEmailAndPassword
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  34.8 kB
  34.9 kB
  +84 B (+0.2%)
  size-with-ext-deps
  46.9 kB
  47.0 kB
  +84 B (+0.2%)
- signInWithEmailLink
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  35.0 kB
  35.1 kB
  +84 B (+0.2%)
  size-with-ext-deps
  47.1 kB
  47.2 kB
  +84 B (+0.2%)
- signInWithPhoneNumber
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  34.8 kB
  34.9 kB
  +84 B (+0.2%)
  size-with-ext-deps
  46.7 kB
  46.8 kB
  +84 B (+0.2%)
- signInWithPopup
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  41.0 kB
  41.1 kB
  +84 B (+0.2%)
  size-with-ext-deps
  52.9 kB
  53.0 kB
  +84 B (+0.2%)
- signInWithRedirect
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  35.6 kB
  35.7 kB
  +84 B (+0.2%)
  size-with-ext-deps
  47.5 kB
  47.6 kB
  +84 B (+0.2%)
- signOut
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  29.8 kB
  29.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.6 kB
  41.7 kB
  +84 B (+0.2%)
- unlink
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  30.4 kB
  30.4 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.2 kB
  42.3 kB
  +84 B (+0.2%)
- updateCurrentUser
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  29.8 kB
  29.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.7 kB
  41.8 kB
  +84 B (+0.2%)
- updateEmail
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  30.1 kB
  30.1 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.9 kB
  42.0 kB
  +84 B (+0.2%)
- updatePassword
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  30.1 kB
  30.2 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.9 kB
  42.0 kB
  +84 B (+0.2%)
- updatePhoneNumber
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  30.5 kB
  30.6 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.4 kB
  42.5 kB
  +84 B (+0.2%)
- updateProfile
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  30.3 kB
  30.3 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.1 kB
  42.2 kB
  +84 B (+0.2%)
- useDeviceLanguage
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  29.8 kB
  29.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.7 kB
  41.7 kB
  +84 B (+0.2%)
- verifyBeforeUpdateEmail
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  30.8 kB
  30.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.7 kB
  42.8 kB
  +84 B (+0.2%)
- verifyPasswordResetCode
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  31.0 kB
  31.1 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.9 kB
  43.0 kB
  +84 B (+0.2%)
- ActionCodeOperation
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  30.0 kB
  30.1 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.9 kB
  41.9 kB
  +84 B (+0.2%)
- AuthErrorCodes
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  34.4 kB
  34.5 kB
  +84 B (+0.2%)
  size-with-ext-deps
  46.3 kB
  46.4 kB
  +84 B (+0.2%)
- FactorId
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  29.8 kB
  29.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.6 kB
  41.7 kB
  +84 B (+0.2%)
- OperationType
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  29.8 kB
  29.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.7 kB
  41.8 kB
  +84 B (+0.2%)
- ProviderId
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  29.9 kB
  30.0 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.7 kB
  41.8 kB
  +84 B (+0.2%)
- SignInMethod
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  29.9 kB
  30.0 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.8 kB
  41.9 kB
  +84 B (+0.2%)
- browserLocalPersistence
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  33.1 kB
  33.2 kB
  +84 B (+0.3%)
  size-with-ext-deps
  45.1 kB
  45.2 kB
  +84 B (+0.2%)
- browserPopupRedirectResolver
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  54.0 kB
  54.1 kB
  +84 B (+0.2%)
  size-with-ext-deps
  66.1 kB
  66.1 kB
  +84 B (+0.1%)
- browserSessionPersistence
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  33.1 kB
  33.2 kB
  +84 B (+0.3%)
  size-with-ext-deps
  45.1 kB
  45.2 kB
  +84 B (+0.2%)
- debugErrorMap
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  40.8 kB
  40.9 kB
  +84 B (+0.2%)
  size-with-ext-deps
  52.7 kB
  52.8 kB
  +84 B (+0.2%)
- inMemoryPersistence
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  29.8 kB
  29.8 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.6 kB
  41.7 kB
  +84 B (+0.2%)
- indexedDBLocalPersistence
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  37.2 kB
  37.3 kB
  +84 B (+0.2%)
  size-with-ext-deps
  49.1 kB
  49.1 kB
  +84 B (+0.2%)
- prodErrorMap
  Size Table
  Type Base (4594d3f) Head (c51c87f) Diff
  size
  29.7 kB
  29.8 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.6 kB
  41.7 kB
  +84 B (+0.2%)

Test Logs

packages/auth/src/platform_browser/auth.test.ts

…ase-js-sdk into sam-gc/onauthstatechanged

Fix double-onAuthStateChanged call bug

e74c7ca

sam-gc assigned lisajian Oct 29, 2021

sam-gc requested review from avolkovi, lisajian and yuchenshi as code owners October 29, 2021 18:42

sam-gc assigned yuchenshi Oct 29, 2021

google-cla bot added the cla: yes label Oct 29, 2021

Add changeset

a8075fc

sam-gc requested a review from egilmorez as a code owner October 29, 2021 18:43

yuchenshi approved these changes Oct 29, 2021

View reviewed changes

packages/auth/src/platform_browser/auth.test.ts Show resolved Hide resolved

sam-gc added 2 commits October 29, 2021 13:01

PR feedback

1c28232

Merge branch 'sam-gc/onauthstatechanged' of github.com:firebase/fireb…

8561fc0

…ase-js-sdk into sam-gc/onauthstatechanged

sam-gc merged commit 0765b5e into master Oct 29, 2021

sam-gc deleted the sam-gc/onauthstatechanged branch October 29, 2021 21:25

google-oss-bot mentioned this pull request Nov 2, 2021

Version Packages #5695

Merged

firebase locked and limited conversation to collaborators Nov 29, 2021

[Auth] Fix double-onAuthStateChanged call bug #5686

[Auth] Fix double-onAuthStateChanged call bug #5686

Uh oh!

Conversation

sam-gc commented Oct 29, 2021

changeset-bot bot commented Oct 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

google-oss-bot commented Oct 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Binary Size Report

Affected SDKs

@firebase/auth/cordova

@firebase/auth/internal

@firebase/auth/react-native

firebase

Test Logs

google-oss-bot commented Oct 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report

Affected Products

@firebase/auth

ActionCodeURL

AuthCredential

EmailAuthCredential

EmailAuthProvider

FacebookAuthProvider

GithubAuthProvider

GoogleAuthProvider

OAuthCredential

OAuthProvider

PhoneAuthCredential

PhoneAuthProvider

PhoneMultiFactorGenerator

RecaptchaVerifier

SAMLAuthProvider

TwitterAuthProvider

applyActionCode

checkActionCode

confirmPasswordReset

connectAuthEmulator

createUserWithEmailAndPassword

deleteUser

fetchSignInMethodsForEmail

getAdditionalUserInfo

getAuth

getIdToken

getIdTokenResult

getMultiFactorResolver

getRedirectResult

initializeAuth

isSignInWithEmailLink

linkWithCredential

linkWithPhoneNumber

linkWithPopup

linkWithRedirect

multiFactor

onAuthStateChanged

onIdTokenChanged

parseActionCodeURL

reauthenticateWithCredential

reauthenticateWithPhoneNumber

reauthenticateWithPopup

reauthenticateWithRedirect

reload

sendEmailVerification

sendPasswordResetEmail

sendSignInLinkToEmail

setPersistence

signInAnonymously

signInWithCredential

signInWithCustomToken

signInWithEmailAndPassword

signInWithEmailLink

signInWithPhoneNumber

signInWithPopup

signInWithRedirect

signOut

unlink

updateCurrentUser

changeset-bot bot commented Oct 29, 2021 •

edited

Loading

google-oss-bot commented Oct 29, 2021 •

edited

Loading

`@firebase/auth/cordova`

`@firebase/auth/internal`

`@firebase/auth/react-native`

`firebase`

google-oss-bot commented Oct 29, 2021 •

edited

Loading

`@firebase/auth`

`ActionCodeURL`

`AuthCredential`

`EmailAuthCredential`

`EmailAuthProvider`

`FacebookAuthProvider`

`GithubAuthProvider`

`GoogleAuthProvider`

`OAuthCredential`

`OAuthProvider`

`PhoneAuthCredential`

`PhoneAuthProvider`

`PhoneMultiFactorGenerator`

`RecaptchaVerifier`

`SAMLAuthProvider`

`TwitterAuthProvider`

`applyActionCode`

`checkActionCode`

`confirmPasswordReset`

`connectAuthEmulator`

`createUserWithEmailAndPassword`

`deleteUser`

`fetchSignInMethodsForEmail`

`getAdditionalUserInfo`

`getAuth`

`getIdToken`

`getIdTokenResult`

`getMultiFactorResolver`

`getRedirectResult`

`initializeAuth`

`isSignInWithEmailLink`

`linkWithCredential`

`linkWithPhoneNumber`

`linkWithPopup`

`linkWithRedirect`

`multiFactor`

`onAuthStateChanged`

`onIdTokenChanged`

`parseActionCodeURL`

`reauthenticateWithCredential`

`reauthenticateWithPhoneNumber`

`reauthenticateWithPopup`

`reauthenticateWithRedirect`

`reload`

`sendEmailVerification`

`sendPasswordResetEmail`

`sendSignInLinkToEmail`

`setPersistence`

`signInAnonymously`

`signInWithCredential`

`signInWithCustomToken`

`signInWithEmailAndPassword`

`signInWithEmailLink`

`signInWithPhoneNumber`

`signInWithPopup`

`signInWithRedirect`

`signOut`

`unlink`

`updateCurrentUser`

`updateEmail`

`updatePassword`

`updatePhoneNumber`

`updateProfile`

`useDeviceLanguage`

`verifyBeforeUpdateEmail`

`verifyPasswordResetCode`

`ActionCodeOperation`

`AuthErrorCodes`

`FactorId`

`OperationType`

`ProviderId`

`SignInMethod`

`browserLocalPersistence`